Skip to content

Commit

Permalink
Pin create-next-app to eslint@v7 (#29837)
Browse files Browse the repository at this point in the history
Fixes vercel/next.js#29770

## Description

Pins `eslint` to `v7`. This avoids issues with `v8` from both [changes to the public api](https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#the-lib-entrypoint-has-been-removed) and [lack of support from rushstack](microsoft/rushstack#2890). See vercel/next.js#29770 (comment) for slightly more detail. 

Local testing showed output of next app correctly pinned to `v7`. 

<img width="495" alt="Screen Shot 2021-10-12 at 12 31 56 AM" src="https://user-images.githubusercontent.com/29002354/136892312-1571718c-882b-4235-98f4-c1b8d4c72d26.png">


### Bug Checklist

- [X] Related issues linked using `fixes #number`
- [ ] Integration tests added
   - Happy to add an integration test for pinning to v7 if we'd like, will need to be updated / removed when v8 is supported. 
- [ ] Errors have helpful link attached, see `contributing.md`
	- No errors to add links for
  • Loading branch information
finn-orsini committed Oct 12, 2021
1 parent 836890c commit 3702f4f
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion create-app.ts
Expand Up @@ -230,7 +230,7 @@ export async function createApp({
/**
* Default devDependencies.
*/
const devDependencies = ['eslint', 'eslint-config-next']
const devDependencies = ['eslint@7', 'eslint-config-next']
/**
* TypeScript projects will have type definitions and other devDependencies.
*/
Expand Down

0 comments on commit 3702f4f

Please sign in to comment.