[v6] Fix wrong serialization of PKESK v6 for x25519/x448 #1734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twiss
reviewed
Mar 21, 2024
The cleartext session key symmetric algorithm was accidentally included in the packet. As a result, the generated messages may fail to parse and/or decrypt in other implementations. The messages would still decrypt successfully in OpenPGP.js, due to an overly permissive parsing procedure, which simply discarded the unused additional byte.
larabr
force-pushed
the
v6-fix-eddsa-pkesk-v6-encrypt
branch
from
38f4450
to
8a0c60f
Compare
twiss
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cleartext session key symmetric algorithm was accidentally included in the packet.
As a result, the generated messages could fail to parse and/or decrypt in other implementations.
The messages would still decrypt successfully in OpenPGP.js, due to a laax parsing procedure, which simply discarded the unused additional byte.
This only affects v6 PKESK packets, that are only generated starting from OpenPGP.js v6, if the keys were generated enabling
config.aeadProtect(off by default).