-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Beginning ofTypescript migration & S2K Gnu case refactor #1709
Open
Realtin
wants to merge
13
commits into
openpgpjs:v6
Choose a base branch
from
neighbourhoodie:typescript-migration2
base: v6
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
48bd1a0
Refactor: s2k module to Typescrip
Realtin 774e619
Add: Typescript configuration
Realtin 2b49d9d
refactor: gnu s2k type to its own class
ayhamthemayhem df654e7
fix: remove unused import
ayhamthemayhem 61866e1
refactor: gnu s2k type to its own class
ayhamthemayhem a240fb5
fix: remove unused import
ayhamthemayhem 2983d22
refactor: s2k uses gnuType for dummy keys
Realtin 888f149
refactor: add Config type instead of defaultConfig
Realtin ffd6ffb
Merge branch 'typescript-migration-gnus2k-refactor' into typescript-m…
Realtin 51c6f97
fix: type errors
ayhamthemayhem 221cb45
add: private notations to private values in generec class
ayhamthemayhem 64138a3
fix: throw error if salt is not defined
ayhamthemayhem e3302d6
fix: add type definitions for s2kNames
ayhamthemayhem File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there technical reasons to not use the official plugin?
I'd rather go with that one if it's an option, for security reasons.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we went with this one because it prints typeScript diagnostic messages when bundling the code while the official ones does not and I feel this why we wanted to move to typescript in the first place.