Fix forward compatibility of keys, SKESKs, and detached/cleartext signatures and ECDH #1656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
changed the title
larabr
force-pushed
the
fix-fwd-compat-detached-verify
branch
2 times, most recently
from
05f0564
to
dd006d1
Compare
twiss
reviewed
Jun 29, 2023
| try { | ||
| offset += this.s2k.read(bytes.subarray(offset, bytes.length)); | ||
| } catch (err) { | ||
| throw new UnsupportedError('Unsupported or invalid S2K'); |
There was a problem hiding this comment.
Can we change the type of the errors in s2k.read instead? (And add a try/catch around the enums.read there, I guess)
There was a problem hiding this comment.
Yes, we just have to merge this after #1658
larabr
force-pushed
the
fix-fwd-compat-detached-verify
branch
from
dd006d1
to
225ec7d
Compare
larabr
changed the title
larabr
force-pushed
the
fix-fwd-compat-detached-verify
branch
from
368f0e4
to
b638edd
Compare
twiss
approved these changes
Jul 8, 2023
…e packet versions Relevant for forward compatibility when verifying detached signatures that include e.g. v4 and v6 packets
…re packet versions
These messages should still be decrypt-able if they include at least one supported ESK packet.
Keys with such subkeys should still be usable, as long as they have a supported primary key.
larabr
force-pushed
the
fix-fwd-compat-detached-verify
branch
from
b638edd
to
32caf41
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant for forward compatibility when:
UnparseablePacketto properly deal with key blocks that include malformed/unsupported packets #1522 .