[v6] Relax constraints for UserID email address validity #1641
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
force-pushed
the
v6
branch
3 times, most recently
from
2951fe8
to
b8995e7
Compare
larabr
force-pushed
the
v6-relax-userid-checks
branch
from
550a6ca
to
a97e623
Compare
larabr
force-pushed
the
v6
branch
2 times, most recently
from
76a8511
to
7881b85
Compare
New checks align with the HTML5 W3C spec and should be more lax than the existing ones (meaning, addresses which passed validation before should continue to be valid). Addresses such as @localhost are now allowed too, since presence of "." is no longer enforced. These checks should not be considered exhaustive: library users are encouraged to implement separate checks for email validity if needed.
larabr
force-pushed
the
v6-relax-userid-checks
branch
from
a97e623
to
7d7a8dc
Compare
twiss
reviewed
Feb 2, 2024
Co-authored-by: Daniel Huigens <d.huigens@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New checks align with the HTML5 W3C spec and should be more lax than the existing ones (meaning, addresses which passed validation before should continue to be valid). Addresses with domain such as
@localhostare now allowed too, since presence of "." is no longer enforced.These checks should not be considered exhaustive: library users are encouraged to implement separate checks for email validity if needed.