Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add typescript setup notice #1586

Merged
merged 3 commits into from Jan 30, 2023
Merged

docs: add typescript setup notice #1586

merged 3 commits into from Jan 30, 2023

Conversation

KnisterPeter
Copy link
Contributor

@KnisterPeter KnisterPeter commented Jan 27, 2023 •
edited

Mention that openpgpjs does needs types from @openpgp/web-stream-tools.

Reference: #1502 (comment)

@KnisterPeter
docs: add typescript setup notice
d8e7aaa 
Mention that `openpgpjs` does needs types from `@openpgp/web-stream-tools`.
@KnisterPeter KnisterPeter mentioned this pull request Jan 27, 2023
Merged
1 task
larabr
larabr reviewed Jan 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
larabr
larabr reviewed Jan 30, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
@larabr larabr self-requested a review January 30, 2023 13:24
larabr
larabr requested changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@larabr larabr left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, I would change the text to clarify our stance and also invite people to report mistakes :) See proposed changes

KnisterPeter and others added 2 commits January 30, 2023 14:32
@KnisterPeter @larabr
Update README.md
0e5f5b6 
Co-authored-by: larabr <larabr+github@protonmail.com>
@KnisterPeter @larabr
Update README.md
966eb94 
Co-authored-by: larabr <larabr+github@protonmail.com>
larabr
larabr approved these changes Jan 30, 2023
View reviewed changes
Copy link
Collaborator

@larabr larabr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for the help 🙂

@KnisterPeter
Copy link
Contributor Author

Thanks for creating this project 😃

@larabr larabr merged commit 50ea1ac into openpgpjs:main Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larabr larabr larabr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KnisterPeter @larabr