Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: create annotations on performance regression warnings/errors #1441

Merged
merged 5 commits into from Nov 18, 2021
Merged

CI: create annotations on performance regression warnings/errors #1441

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9c4cbdd
CI: add annotations for performance regression warning/errors
larabr Nov 16, 2021
d4ecad9
Try path relative to repo
larabr Nov 16, 2021
23d80ca
Try path relative to workspace
larabr Nov 16, 2021
0ebacd6
Capitalise
larabr Nov 16, 2021
ff495f3
Disable commenting on alerts to reduce noise
larabr Nov 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 7 additions & 4 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Expand Up @@ -39,26 +39,29 @@ jobs:
uses: openpgpjs/github-action-pull-request-benchmark@v1
with:
tool: 'benchmarkjs'
name: 'time benchmark'
name: 'Time benchmark'
pr-benchmark-file-path: pr/benchmarks.txt
base-benchmark-file-path: master/benchmarks.txt
github-token: ${{ secrets.GITHUB_TOKEN }}
# trigger alert comment if 1.3 times slower
alert-threshold: '130%'
comment-on-alert: true
comment-on-alert: false
# fail workdlow if 1.5 times slower
fail-threshold: '150%'
fail-on-alert: true
file-to-annotate: ${{ github.workspace }}/test/benchmarks/time.js

- name: Compare memory usage benchmark result
uses: openpgpjs/github-action-pull-request-benchmark@v1
with:
tool: 'raw'
name: 'memory usage benchmark'
name: 'Memory usage benchmark'
pr-benchmark-file-path: pr/memory_usage.txt
base-benchmark-file-path: master/memory_usage.txt
github-token: ${{ secrets.GITHUB_TOKEN }}
alert-threshold: '102%'
comment-on-alert: true
comment-on-alert: false
fail-threshold: '110%'
fail-on-alert: true
file-to-annotate: ${{ github.workspace }}/test/benchmarks/memory_usage.js