Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various signature verification issues #1302

Merged
merged 22 commits into from
Jun 8, 2021

Conversation

larabr
Copy link
Collaborator

@larabr larabr commented May 12, 2021

Breaking changes in function signatures:

  • changes to date param:
    • Key.update(key, config) -> update(key, date, config)
    • Key.applyRevocationCertificate(revocationCertificate, config) -> applyRevocationCertificate(revocationCertificate, date, config)
    • Key.signAllUsers(privateKeys, config) -> signAllUsers(privateKeys, date, config)
    • Key.verifyAllUsers(keys, config) -> verifyAllUsers(keys, date, config)
    • SignaturePacket.constructor(date) -> constructor(void)
    • SignaturePacket.sign(key, data, detached) -> sign(key, data, date, detached)
    • Message.sign(primaryKey, privateKeys, config) -> sign(primaryKey, privateKeys, date, config)
    • Message.decrypt(privateKeys, passwords, sessionKeys, config) -> decrypt(privateKeys, passwords, sessionKeys, date, config)
    • Message.decryptSessionKeys(privateKeys, passwords, config) -> decryptSessionKeys(privateKeys, passwords, date, config)
  • removed primaryKey param:
    • SubKey.isRevoked(primaryKey, signature, key, date, config) -> isRevoked(signature, key, date, config)
    • SubKey.update(subKey, primaryKey, date, config) -> update(subKey, date, config)
    • SubKey.getExpirationTime(primaryKey, date, config) -> getExpirationTime(date, config)

@larabr larabr marked this pull request as ready for review May 13, 2021 16:45
@larabr larabr force-pushed the fix-signature-missing-time branch from 39d519f to 730f19a Compare May 17, 2021 16:21
src/key/helper.js Outdated Show resolved Hide resolved
src/key/key.js Outdated Show resolved Hide resolved
src/message.js Outdated Show resolved Hide resolved
src/packet/signature.js Outdated Show resolved Hide resolved
src/packet/signature.js Show resolved Hide resolved
src/packet/signature.js Outdated Show resolved Hide resolved
src/packet/signature.js Outdated Show resolved Hide resolved
src/packet/signature.js Outdated Show resolved Hide resolved
@larabr larabr force-pushed the fix-signature-missing-time branch from 3d2bd48 to bd30bc7 Compare May 27, 2021 13:52
…tExpirationTime to always return latest expiration time
@larabr larabr force-pushed the fix-signature-missing-time branch from a9c78f9 to d9d4ce4 Compare May 29, 2021 19:06
test/general/key.js Outdated Show resolved Hide resolved
test/general/key.js Outdated Show resolved Hide resolved
src/packet/signature.js Outdated Show resolved Hide resolved
src/key/key.js Outdated Show resolved Hide resolved
src/key/key.js Outdated Show resolved Hide resolved
src/key/subkey.js Outdated Show resolved Hide resolved
src/message.js Outdated Show resolved Hide resolved
src/packet/signature.js Outdated Show resolved Hide resolved
src/packet/signature.js Outdated Show resolved Hide resolved
src/packet/signature.js Show resolved Hide resolved
@larabr larabr requested a review from twiss June 1, 2021 10:45
@danhab99
Copy link
Contributor

Hey I just noticed that the typedef for revokeKey is not in the typedefs file. Could that be added?

@twiss
Copy link
Member

twiss commented Jun 14, 2021

See #1324 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants