-
Notifications
You must be signed in to change notification settings - Fork 790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various signature verification issues #1302
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
commented
May 13, 2021
larabr
force-pushed
the
fix-signature-missing-time
branch
from
May 17, 2021 16:21
39d519f
to
730f19a
Compare
larabr
commented
May 17, 2021
twiss
reviewed
May 21, 2021
twiss
reviewed
May 26, 2021
… expiration check inside SignaturePacket.verify
larabr
force-pushed
the
fix-signature-missing-time
branch
from
May 27, 2021 13:52
3d2bd48
to
bd30bc7
Compare
twiss
reviewed
May 28, 2021
…tExpirationTime to always return latest expiration time
larabr
force-pushed
the
fix-signature-missing-time
branch
from
May 29, 2021 19:06
a9c78f9
to
d9d4ce4
Compare
twiss
reviewed
May 31, 2021
twiss
approved these changes
Jun 8, 2021
Hey I just noticed that the typedef for |
See #1324 :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
openpgp.readSignature
) if the creation time subpacket is missing from the hashed area.SignaturePacket.verify
now directly checks for signature expiration and signatures created in the future. This makes it easier to thoroughly check the validity of signatures. Also:openpgp.revokeKey
now takes adate
to check the provided revocation certificateopenpgp.decryptSessionKeys
now takes adate
to check the validity of the provided private keysdate
is used internally, the function accepts adate
param to allow for proper time sync.openpgp.generateKey
,openpgp.reformatKey
now also requiresoptions.userIDs
(follow up to RemoveKey.prototype.encrypt()
andKey.prototype.decrypt()
#1285).SubKey.isRevoked/update/getExpirationTime
by adding theSubKey.mainKey
field to hold the reference of the correspondingKey
.Breaking changes in function signatures:
date
param:Key.update(key, config)
->update(key, date, config)
Key.applyRevocationCertificate(revocationCertificate, config)
->applyRevocationCertificate(revocationCertificate, date, config)
Key.signAllUsers(privateKeys, config)
->signAllUsers(privateKeys, date, config)
Key.verifyAllUsers(keys, config)
->verifyAllUsers(keys, date, config)
SignaturePacket.constructor(date)
->constructor(void)
SignaturePacket.sign(key, data, detached)
->sign(key, data, date, detached)
Message.sign(primaryKey, privateKeys, config)
->sign(primaryKey, privateKeys, date, config)
Message.decrypt(privateKeys, passwords, sessionKeys, config)
->decrypt(privateKeys, passwords, sessionKeys, date, config)
Message.decryptSessionKeys(privateKeys, passwords, config)
->decryptSessionKeys(privateKeys, passwords, date, config)
primaryKey
param:SubKey.isRevoked(primaryKey, signature, key, date, config)
->isRevoked(signature, key, date, config)
SubKey.update(subKey, primaryKey, date, config)
->update(subKey, date, config)
SubKey.getExpirationTime(primaryKey, date, config)
->getExpirationTime(date, config)