Make PacketList a valid subtype of Array and update Packet.tag type accessor
#1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larabr
commented
Apr 20, 2021
larabr
changed the title
PacketList a valid subtype of ArrayPacketList a valid subtype of Array and update Packet.tag type accessor
larabr
force-pushed
the
fix-packetlist-types
branch
from
9c41bb9
to
cc17eed
Compare
…d tests for more packet methods
larabr
commented
Apr 22, 2021
twiss
reviewed
Apr 23, 2021
twiss
reviewed
Apr 29, 2021
| @@ -81,7 +81,7 @@ async function makeKeyValid() { | |||
| pusersig.readSubPackets(fake.writeHashedSubPackets(), false); | |||
| // reconstruct the modified key | |||
| const newlist = new PacketList(); | |||
| newlist.concat([pubkey, puser, pusersig]); | |||
| newlist.push(...[pubkey, puser, pusersig]); | |||
There was a problem hiding this comment.
This is then very nitpicky but you can just do:
Suggested change
| newlist.push(...[pubkey, puser, pusersig]); | |
| newlist.push(pubkey, puser, pusersig); |
There was a problem hiding this comment.
Yes this is fixed in the next PR 🙃
| @@ -56,7 +56,7 @@ async function testSubkeyTrust() { | |||
| fakeBindingSignature.keyFlags = [enums.keyFlags.signData]; | |||
| await fakeBindingSignature.sign(attackerPrivKey.keyPacket, dataToSign); | |||
| const newList = new PacketList(); | |||
| newList.concat([ | |||
| newList.push(...[ | |||
twiss
approved these changes
Apr 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
PacketList.prototype.concatandpush(we solely rely onArray.pushinstead).filterByTag.write()method forTrustandMarkerpackets, to make them compatible with theBasePacketinterfacePacketListtype definitionsPacket.tag, which isstaticsince Use consistent name casing #1268