IndexStatsView: fix "invalid date" error #854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schu
changed the title
schu
force-pushed
the
schu/safari-fix-invalid-date
branch
from
fa47f1a
to
46b6520
Compare
The stats graph on the index page shows hourly answer and user counts on hover. Though with Safari the label doesn't show the datetime but an error message "invalid date". This is because the datetime string as received from the API doesn't adhere to a standard datetime format (by default, datetime fields are stored as UTC in the format `2018-01-01 00:00:00`). Update the scheduled stats routine to send datetime keys in ISO 8601 format (https://en.wikipedia.org/wiki/ISO_8601) and update the frontend code to use date-fns's `parseISO` to parse the date from the label context for the local time zone. Also, change the index stats graph to show at most 4 ticks on the y-axis. Resolves #853
schu
force-pushed
the
schu/safari-fix-invalid-date
branch
from
46b6520
to
66bc531
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The stats graph on the index page shows hourly answer and user counts on hover. Though with Safari the label doesn't show the datetime but an error message "invalid date". This is because the datetime string as received from the API doesn't adhere to a standard datetime format (by default, datetime fields are stored as UTC in the format
2018-01-01 00:00:00).Update the scheduled stats routine to send datetime keys in ISO 8601 format (https://en.wikipedia.org/wiki/ISO_8601) and update the frontend code to use date-fns's
parseISOto parse the date from the label context for the local time zone.Also, change the index stats graph to show at most 4 ticks on the y-axis.
Resolves #853