Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PrestoS3FileSystem.java #403

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ShefronYudy
Copy link

The LOG.debug("destination does not exist"); should be log.debug("destination does not exist");, because the LOG is parent FileSystem's reference.

What type of PR is this?

bug

What does this PR do / why do we need it:

When use LOG to print some messages, The log class of log message is not the current PrestoS3FileSystem, but the parent FileSystem.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewers:

The `LOG.debug("destination does not exist");` should be `log.debug("destination does not exist");`, because the `LOG` is parent FileSystem's reference.
@it-is-a-robot
Copy link
Contributor

Thanks for your pull request.

The authors of the following commits have not signed the Contributor License Agreement (CLA):

83e1395 | Update PrestoS3FileSystem.java

The LOG.debug("destination does not exist"); should be log.debug("destination does not exist");, because the LOG is parent FileSystem's reference.

Please check the FAQs first.
You can click here to sign the CLA. After signing the CLA, you must comment "/check-cla" to check the CLA status again.

@it-is-a-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: ShefronYudy
To complete the pull request process, please assign haochending
You can assign the PR to them by writing /assign @haochending in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@it-is-a-robot
Copy link
Contributor

Welcome @ShefronYudy!

It looks like this is your first PR to openlookeng/hetu-core 🎉.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if openlookeng/hetu-core has its own contribution guidelines. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to MindSpore. 😃

@Nitin-Kashyap
Copy link
Contributor

/sync

@it-is-a-robot
Copy link
Contributor

@Nitin-Kashyap: sync pull request is restricted to collaborators

In response to this:

/sync

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the opensourceways/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants