Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#340 CTE support for snapshot #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

codewithaloknath
Copy link
Contributor

What type of PR is this?

CTE support for snapshot

Which issue(s) this PR fixes:

#340

Fixes #340

Special notes for your reviewers:

@it-is-a-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: codewithaloknath
To complete the pull request process, please assign lizheng920625
You can assign the PR to them by writing /assign @lizheng920625 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

@Nitin-Kashyap Nitin-Kashyap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Changes seems to incomplete; CTE flows are not handled fully.
  2. Also, ReuseScan is not handled even though code removes the sanity chekcs for the same.
  3. No testcase guarding the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CTE support for snapshot
3 participants