Add includePatterns and excludePatterns support for copy #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, think we just need to update generated content with |
hinshun
reviewed
Apr 29, 2021
pkg/llbutil/llbutil.go
Outdated
| } | ||
|
|
||
| func (ip CopyIncludePatterns) SetCopyOption(ci *llb.CopyInfo) { | ||
| ci.IncludePatterns = ([]string)(ip) |
There was a problem hiding this comment.
I think we want to append? What do users expect when they do something like:
copy foo "/" "/" with option {
includePatterns "a"
includePatterns "b"
}
This example may be in practical scenarios when trying to refactor an copy::option function with common patterns but also want to extend with additional patterns.
|
Overall looks good. Pending upstream PRs to be merged. |
aaronlehmann
force-pushed
the
copy-include-exclude
branch
from
39a579e
to
dc3615d
Compare
|
@hinshun: Updated. |
Tested with:
```
fs busybox() {
image "busybox"
}
fs copyWithPatterns() {
copy busybox "/bin" "/" with option {
includePatterns "x*"
excludePatterns "xargs"
}
download "."
}
```
aaronlehmann
force-pushed
the
copy-include-exclude
branch
from
dc3615d
to
e60d1d9
Compare
hinshun
approved these changes
Jun 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested with:
Depends on upstream PRs tonistiigi/fsutil#101 and moby/buildkit#2082