8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'

[MBaesken]

This coding, with ubsan enabled
bool force_reexecute() const { return _force_reexecute; }

gives us on Linux x86_64 fastdebug the following warning :

/jdk/src/hotspot/share/c1/c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'
#0 0x14b3999f2921 in ValueStack::force_reexecute() const /jdk/src/hotspot/share/c1/c1_ValueStack.hpp:229
#1 0x14b3999f2921 in LIRGenerator::do_ArrayCopy(Intrinsic*) /jdk/src/hotspot/cpu/x86/c1_LIRGenerator_x86.cpp:1008
#2 0x14b39aa1c077 in LIRGenerator::do_root(Instruction*) /jdk/src/hotspot/share/c1/c1_LIRGenerator.cpp:379
#3 0x14b39aa2df94 in non-virtual thunk to LIRGenerator::block_do(BlockBegin*) (/net/usr.work/d040975/open_jdk/jdk_6/build_clx209_fastdebug/jdk/lib/server/libjvm.so+0x5ad1f94)
#4 0x14b39a971ff6 in BlockList::iterate_forward(BlockClosure*) /jdk/src/hotspot/share/c1/c1_Instruction.cpp:891
#5 0x14b39a878114 in Compilation::emit_lir() /jdk/src/hotspot/share/c1/c1_Compilation.cpp:264
#6 0x14b39a882076 in Compilation::compile_java_method() /jdk/src/hotspot/share/c1/c1_Compilation.cpp:407
#7 0x14b39a884c48 in Compilation::compile_method() /jdk/src/hotspot/share/c1/c1_Compilation.cpp:479
#8 0x14b39a88681a in Compilation::Compilation(AbstractCompiler*, ciEnv*, ciMethod*, int, BufferBlob*, bool, DirectiveSet*) /jdk/src/hotspot/share/c1/c1_Compilation.cpp:609
#9 0x14b39a88bd63 in Compiler::compile_method(ciEnv*, ciMethod*, int, bool, DirectiveSet*) /jdk/src/hotspot/share/c1/c1_Compiler.cpp:260
#10 0x14b39b153241 in CompileBroker::invoke_compiler_on_method(CompileTask*) /jdk/src/hotspot/share/compiler/compileBroker.cpp:2303
#11 0x14b39b154d3e in CompileBroker::compiler_thread_loop() /jdk/src/hotspot/share/compiler/compileBroker.cpp:1961
#12 0x14b39bdb17bc in JavaThread::thread_main_inner() /jdk/src/hotspot/share/runtime/javaThread.cpp:759
#13 0x14b39d8a828f in Thread::call_run() /jdk/src/hotspot/share/runtime/thread.cpp:225
... (rest of output omitted)

Seems we miss initializations of the variable _force_reexecute , and this can lead to arbitrary values at the address in memory where _force_reexecute is stored.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'

Issue

• JDK-8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool' (Bug - P4)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Martin Doerr (@TheRealMDoerr - Reviewer)
• Tobias Hartmann (@TobiHartmann - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19284/head:pull/19284
$ git checkout pull/19284

Update a local copy of the PR:
$ git checkout pull/19284
$ git pull https://git.openjdk.org/jdk.git pull/19284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19284

View PR using the GUI difftool:
$ git pr show -t 19284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19284.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332462: ubsan: c1_ValueStack.hpp:229:49: runtime error: load of value 171, which is not a valid value for type 'bool'

Reviewed-by: chagedorn, mdoerr, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• ce99198: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
• f5ab7df: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
• 9f77793: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
• fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
• 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments
• b78613b: 8332154: Memory leak in SynchronousQueue
• 7652f98: 8331885: C2: meet between unloaded and speculative types is not symmetric
• d6b7f9b: 8331851: Add specific regression leap year tests for Calendar.roll()
• b92bd67: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs
• 8acdd2d: 8330565: C2: Multiple crashes with CTW after JDK-8316991
• ... and 4 more: https://git.openjdk.org/jdk/compare/44bdf9964eb2dd0eb4034576e1f903a27c410286...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@MBaesken The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (922728be)

[chhagedorn]

Looks good!

[TobiHartmann]

Looks good to me.

[MBaesken]

/integrate

[openjdk]

Going to push as commit 8a49d47.
Since your change was applied there have been 14 commits pushed to the master branch:

• ce99198: 8332181: Deprecate for removal the MulticastSocket.send(DatagramPacket, byte) and setTTL/getTTL methods on DatagramSocketImpl and MulticastSocket
• f5ab7df: 8332494: java/util/zip/EntryCount64k.java failing with java.lang.RuntimeException: '\A\Z' missing from stderr
• 9f77793: 8332495: java/util/logging/LoggingDeadlock2.java fails with AssertionError: Some tests failed
• fb45bab: 8075917: The regression-swing case failed as the text on label is not painted red with the GTK L&F
• 6e80512: 8332545: Fix handling of HTML5 entities in Markdown comments
• b78613b: 8332154: Memory leak in SynchronousQueue
• 7652f98: 8331885: C2: meet between unloaded and speculative types is not symmetric
• d6b7f9b: 8331851: Add specific regression leap year tests for Calendar.roll()
• b92bd67: 8332403: Anachronistic reference to Netscape Communicator in Swing API docs
• 8acdd2d: 8330565: C2: Multiple crashes with CTW after JDK-8316991
• ... and 4 more: https://git.openjdk.org/jdk/compare/44bdf9964eb2dd0eb4034576e1f903a27c410286...master

Your commit was automatically rebased without conflicts.

[openjdk]

@MBaesken Pushed as commit 8a49d47.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.