-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null #19283
Conversation
👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into |
@MBaesken This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 17 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right, because GrowableArray
will not allocate anything when the passed in capacity
is 0 and will set the data pointer to null. This turns out not to be a problem in practice, as the length of the array is 0 (and so the pointer should not be dereferenced). I'm OK with this.
Hi Johan, thanks for the review . btw seems I found a similar one
but here it is memcpy not qsort . More info can be found here bellard/quickjs#225 |
/integrate |
Going to push as commit e529101.
Your commit was automatically rebased without conflicts. |
@MBaesken Thank you for your efforts of making the ubsan actually usable! |
On Linux x86_64 fastdebug with ubsan enabled we run into this error because we call qsort with a first parameter that is null.
/jdk/src/hotspot/share/utilities/growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
#0 0x150d701bb4b1 in GrowableArrayView<nmethod*>::sort(int ()(nmethod**, nmethod**)) /jdk/src/hotspot/share/utilities/growableArray.hpp:290
#1 0x150d701bb4b1 in ClassUnloadingContext::free_nmethods() /jdk/src/hotspot/share/gc/shared/classUnloadingContext.cpp:159
#2 0x150d71f5cca3 in G1CollectedHeap::unload_classes_and_code(char const, BoolObjectClosure*, GCTimer*) /jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:2538
#3 0x150d71ffb009 in G1FullCollector::phase1_mark_live_objects() /jdk/src/hotspot/share/gc/g1/g1FullCollector.cpp:330
#4 0x150d71ffc675 in G1FullCollector::collect() /jdk/src/hotspot/share/gc/g1/g1FullCollector.cpp:209
#5 0x150d71f3e593 in G1CollectedHeap::do_full_collection(bool, bool) /jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:842
#6 0x150d71f5b12d in G1CollectedHeap::satisfy_failed_allocation_helper(unsigned long, bool, bool, bool, bool*) /jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:917
#7 0x150d71f5b3dc in G1CollectedHeap::satisfy_failed_allocation(unsigned long, bool*) /jdk/src/hotspot/share/gc/g1/g1CollectedHeap.cpp:930
#8 0x150d721835f7 in VM_G1CollectForAllocation::doit() /jdk/src/hotspot/share/gc/g1/g1VMOperations.cpp:127
#9 0x150d74291ec8 in VM_Operation::evaluate() /jdk/src/hotspot/share/runtime/vmOperations.cpp:75
#10 0x150d742ca1be in VMThread::evaluate_operation(VM_Operation*) /jdk/src/hotspot/share/runtime/vmThread.cpp:283
#11 0x150d742cb9e7 in VMThread::inner_execute(VM_Operation*) /jdk/src/hotspot/share/runtime/vmThread.cpp:427
#12 0x150d742cc601 in VMThread::loop() /jdk/src/hotspot/share/runtime/vmThread.cpp:493
#13 0x150d742cc601 in VMThread::loop() /jdk/src/hotspot/share/runtime/vmThread.cpp:478
seems we sometimes call qsort with nullptr as first parameter, this is not recommended.
When adding a guarantee the same can be seen (_data is null).
So better add a check and do not sort, if there is nothing provided to be sorted .
Progress
Warning
8332473: ubsan: growableArray.hpp:290:10: runtime error: null pointer passed as argument 1, which is declared to never be null
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19283/head:pull/19283
$ git checkout pull/19283
Update a local copy of the PR:
$ git checkout pull/19283
$ git pull https://git.openjdk.org/jdk.git pull/19283/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19283
View PR using the GUI difftool:
$ git pr show -t 19283
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19283.diff
Webrev
Link to Webrev Comment