Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[denonmarantz] Add UoM support for volume dB channels #16759

Merged
merged 1 commit into from
May 14, 2024

Conversation

jlaur
Copy link
Contributor

@jlaur jlaur commented May 13, 2024

VolumeDB channels for all zones are now Number:Dimensionless with unit hint dB.

@jlaur jlaur added the enhancement An enhancement or new feature for an existing add-on label May 13, 2024
@jlaur jlaur force-pushed the denonmarantz-uom-volumedb branch 2 times, most recently from 7b88961 to adece69 Compare May 14, 2024 18:08
@jlaur jlaur marked this pull request as ready for review May 14, 2024 18:37
@jlaur jlaur requested a review from jwveldhuis as a code owner May 14, 2024 18:37
@jlaur jlaur changed the title [denonmarantz] Add UoM support for volume dB channel [denonmarantz] Add UoM support for volume dB channels May 14, 2024
Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Flawless, thanks. LGTM
Can be merged after the conflict is fixed due to the other PR.

@jlaur jlaur force-pushed the denonmarantz-uom-volumedb branch from adece69 to 624e8c0 Compare May 14, 2024 20:49
@jlaur
Copy link
Contributor Author

jlaur commented May 14, 2024

@lsiepel - rebased.

Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
@jlaur jlaur force-pushed the denonmarantz-uom-volumedb branch from 624e8c0 to 4481ff6 Compare May 14, 2024 20:54
@lsiepel lsiepel merged commit 50ce7ca into openhab:main May 14, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone May 14, 2024
@jlaur jlaur deleted the denonmarantz-uom-volumedb branch May 14, 2024 22:09
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
Signed-off-by: Jacob Laursen <jacob-github@vindvejr.dk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants