[PiperTTS] Reduce bundle size #16755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
lolodomo
requested changes
May 19, 2024
...penhab.voice.pipertts/src/main/java/org/openhab/voice/pipertts/internal/PiperTTSService.java
Outdated
Show resolved
Hide resolved
...penhab.voice.pipertts/src/main/java/org/openhab/voice/pipertts/internal/PiperTTSService.java
Outdated
Show resolved
Hide resolved
...penhab.voice.pipertts/src/main/java/org/openhab/voice/pipertts/internal/PiperTTSService.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
lolodomo
added
the
enhancement
|
Thank you for the review! |
PRosenb
pushed a commit
to PRosenb/openhab-addons
that referenced
this pull request
May 22, 2024
* [PiperTTS] Reduce bundle size Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
PRosenb
pushed a commit
to PRosenb/openhab-addons
that referenced
this pull request
May 22, 2024
* [PiperTTS] Reduce bundle size Signed-off-by: Miguel Álvarez <miguelwork92@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made these changes to reduce the size as discussed on openhab/openhab-distro#1643
The add-on now downloads the dependency jar from maven and unpack the required files from it, or it can be provided manually to workaround offline installations.