[dsmr] Fix delivery demand labels #16739
Conversation
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
lsiepel
added
bug
|
Let's wait for @coop-git feedback. |
|
@lsiepel - no update instructions needed? |
I won't expect anyone to notice as it is just a label for a new channel in one milestone. But maybe better to do it anyway. I can come up with a commit later today. |
In that case probably not worth it, since just a regression from a recently merged PR only available in snapshot builds. I guess the real question then is: No update instructions needed for #15038? |
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Added them as they are needed for sure. Only users who downloaded a snapshot and re-created the thing will get a log entry, but that is acceptable. |
bundles/org.openhab.binding.dsmr/src/main/resources/OH-INF/update/instructions.xml
Outdated
Show resolved
Hide resolved
| <properties> | ||
| <property name="thingTypeVersion">1</property> | ||
| </properties> | ||
|
|
There was a problem hiding this comment.
I believe you added this property to the wrong thing type. It should be added to thing id electricity_emucs_v1_0 in file meter_electricity_emucs_v1_0.xml.
| <add-channel id="emeter_actual_demand"> | ||
| <type>dsmr:actualDeliveryBelgiumType</type> | ||
| </add-channel> | ||
| <add-channel id="emeter_maximum_demand_current_month"> |
There was a problem hiding this comment.
You need to provide the label here as well, since the channel overrides it from its channel type.
There was a problem hiding this comment.
I see, wasn't aware, thanks.
Signed-off-by: Leo Siepel <leosiepel@gmail.com>
|
@jlaur 's comments were all handled. Lets merge this PR now to have it in milestone 3. |
* Fix delivery demand labels * Add upgrade instructions Signed-off-by: Leo Siepel <leosiepel@gmail.com>
* Fix delivery demand labels * Add upgrade instructions Signed-off-by: Leo Siepel <leosiepel@gmail.com>
Regression of: #15038 (label names and update instructions)
Fixes: #16731