Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Karaf from 4.4.5 to 4.4.6 #16676

Merged
merged 1 commit into from
May 20, 2024
Merged

Upgrade Karaf from 4.4.5 to 4.4.6 #16676

merged 1 commit into from
May 20, 2024

Conversation

holgerfriedrich
Copy link
Member

  • Sync runtime dependencies with Karaf 4.4.6, most notably:
  • Jetty 9.4.54.v20240208, addresses CVE-2024-22201
  • Pax Logging 2.2.7
  • Pax Web 8.0.27
  • ASM 9.7

Refs: openhab/openhab-core#4181

@holgerfriedrich holgerfriedrich added the awaiting other PR Depends on another PR label Apr 22, 2024
@holgerfriedrich holgerfriedrich mentioned this pull request Apr 22, 2024
Merged
@holgerfriedrich
Upgrade Karaf from 4.4.5 to 4.4.6
8217a04 
* Sync runtime dependencies with Karaf 4.4.6, most status
t notably:
  * Jetty 9.4.54.v20240208, addresses CVE-2024-22201
  * Pax Logging 2.2.7
  * Pax Web 8.0.27
  * ASM 9.7
* Resolve itest runbundles

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@J-N-K J-N-K added rebuild Triggers Jenkins PR build infrastructure Build system and Karaf related issues and PRs security and removed awaiting other PR Depends on another PR labels May 20, 2024
@holgerfriedrich holgerfriedrich removed security infrastructure Build system and Karaf related issues and PRs rebuild Triggers Jenkins PR build labels May 20, 2024
@J-N-K J-N-K added security infrastructure Build system and Karaf related issues and PRs labels May 20, 2024
J-N-K
J-N-K approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@J-N-K J-N-K left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@J-N-K
Copy link
Member

J-N-K commented May 20, 2024 

TEST org.openhab.binding.mqtt.homie.HomieImplementationTest#retrieveOneAttribute() <<< ERROR: 
Expected: is "3.0"
     but: was null
java.lang.AssertionError: 
Expected: is "3.0"
     but: was null
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
	at org.openhab.binding.mqtt.homie.HomieImplementationTest.retrieveOneAttribute(HomieImplementationTest.java:171)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at aQute.tester.bundle.engine.BundleDescriptor.executeChild(BundleDescriptor.java:49)
	at aQute.tester.bundle.engine.BundleEngine.lambda$executeBundle$7(BundleEngine.java:120)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at aQute.tester.bundle.engine.BundleEngine.executeBundle(BundleEngine.java:120)
	at aQute.tester.bundle.engine.BundleEngine.lambda$executeBundle$8(BundleEngine.java:133)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at aQute.tester.bundle.engine.BundleEngine.executeBundle(BundleEngine.java:133)
	at aQute.tester.bundle.engine.BundleEngine.lambda$execute$5(BundleEngine.java:100)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:183)
	at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197)
	at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179)
	at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133)
	at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1845)
	at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509)
	at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499)
	at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:150)
	at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:173)
	at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
	at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596)
	at aQute.tester.bundle.engine.BundleEngine.execute(BundleEngine.java:100)

@holgerfriedrich I'll trigger a rebuild, can you check if that succeeds locally?

@J-N-K J-N-K added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 20, 2024
@holgerfriedrich
Copy link
Member Author

Thanks. It succeeded today in the morning and just right now (Windows).

@holgerfriedrich holgerfriedrich added rebuild Triggers Jenkins PR build and removed rebuild Triggers Jenkins PR build labels May 20, 2024
@jlaur jlaur merged commit d36b123 into openhab:main May 20, 2024
5 checks passed
@jlaur jlaur added this to the 4.2 milestone May 20, 2024
@holgerfriedrich holgerfriedrich deleted the k446 branch May 20, 2024 22:03
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
@holgerfriedrich @PRosenb
Upgrade Karaf from 4.4.5 to 4.4.6 (openhab#16676)
49f5e9c 
* Sync runtime dependencies with Karaf 4.4.6, most status
t notably:
  * Jetty 9.4.54.v20240208, addresses CVE-2024-22201
  * Pax Logging 2.2.7
  * Pax Web 8.0.27
  * ASM 9.7
* Resolve itest runbundles

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
PRosenb pushed a commit to PRosenb/openhab-addons that referenced this pull request May 22, 2024
@holgerfriedrich @PRosenb
Upgrade Karaf from 4.4.5 to 4.4.6 (openhab#16676)
fd14dff 
* Sync runtime dependencies with Karaf 4.4.6, most status
t notably:
  * Jetty 9.4.54.v20240208, addresses CVE-2024-22201
  * Pax Logging 2.2.7
  * Pax Web 8.0.27
  * ASM 9.7
* Resolve itest runbundles

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@J-N-K J-N-K J-N-K approved these changes

@hmerk hmerk Awaiting requested review from hmerk hmerk is a code owner

@cweitkamp cweitkamp Awaiting requested review from cweitkamp cweitkamp is a code owner

@kaikreuzer kaikreuzer Awaiting requested review from kaikreuzer kaikreuzer is a code owner

@mherwege mherwege Awaiting requested review from mherwege mherwege is a code owner

@marcelrv marcelrv Awaiting requested review from marcelrv marcelrv is a code owner

@ssalonen ssalonen Awaiting requested review from ssalonen ssalonen is a code owner

@antroids antroids Awaiting requested review from antroids antroids is a code owner

@BjoernLange BjoernLange Awaiting requested review from BjoernLange BjoernLange is a code owner

@gerrieg gerrieg Awaiting requested review from gerrieg gerrieg is a code owner

@wborn wborn Awaiting requested review from wborn wborn is a code owner

Assignees
No one assigned
Labels
infrastructure Build system and Karaf related issues and PRs security
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@holgerfriedrich @J-N-K @jlaur