Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ephemeris] Binding to make the bridge with core Ephemeris functions #16628

Merged
merged 17 commits into from
May 26, 2024
Merged

[Ephemeris] Binding to make the bridge with core Ephemeris functions #16628

merged 17 commits into from
May 26, 2024

Conversation

clinique
Copy link
Contributor

@clinique clinique commented Apr 7, 2024 •
edited

The Ephemeris Binding makes the bridge with Ephemeris core actions, providing access via Items to Ephemeris data without requiring usage of scripts.

It provides direct access to:

  • default holiday data (thing holiday)
  • personal holidata data file (thing file)
  • daysets (thing dayset)
  • weekend (thing weekend)

The binding will auto create a folder in openhab configuration folder where it expects to find your Jollyday event definition files.
For a debian system : /etc/openhab/misc/ephemeris/

Autodiscovery of Weekend and Holiday is available.

@clinique clinique requested a review from a team as a code owner April 7, 2024 19:14
@jlaur jlaur added the new binding If someone has started to work on a binding. For a new binding PR. label Apr 7, 2024
@lsiepel lsiepel added the work in progress A PR that is not yet ready to be merged label Apr 8, 2024
@lsiepel
Copy link
Contributor

lsiepel commented Apr 8, 2024

Added the WIP tag, as it looks like some work and clarrification is needed. This PR lacks an introduction. As ephemeris allready exists in core for some years, it would be usefull to know what gap this binding fills.
Is it tested or discussed somewhere?

@clinique
Copy link
Contributor Author

clinique commented Apr 8, 2024

Added the WIP tag, as it looks like some work and clarrification is needed. This PR lacks an introduction. As ephemeris allready exists in core for some years, it would be usefull to know what gap this binding fills.
Is it tested or discussed somewhere?

Yes, here https://community.openhab.org/t/ephemeris-binding-4-0-0-0-5-0-0-0/155227

@clinique clinique self-assigned this Apr 9, 2024
@clinique clinique removed the work in progress A PR that is not yet ready to be merged label Apr 21, 2024
@lolodomo
Copy link
Contributor

Same problem here with your file bundles/pom.xml.

@clinique
Copy link
Contributor Author

Same problem here with your file bundles/pom.xml.

@lolodomo : pom.xml rebased

@lolodomo
Copy link
Contributor

@lolodomo : pom.xml rebased

But you added many many blank lines. Why ?

@clinique
Copy link
Contributor Author

@lolodomo : pom.xml rebased

But you added many many blank lines. Why ?

You can be assured that I did not do that myself :-) something went wrong somewhere...weird. I'm going to restore it the same way I just did for edf.

@lolodomo
Copy link
Contributor

You can be assured that I did not do that myself :-) something went wrong somewhere

Yes, I believe I already found that when running the script that creates the skeleton of a new binding. I thing there is even an issue still opened for that.

@lolodomo
Copy link
Contributor

I will have a look at this small new binding.

@lolodomo
Copy link
Contributor

@clinique : can you provide few use cases where this binding is useful compared to actions already provided by the core framework?

@clinique
Copy link
Contributor Author

clinique commented May 19, 2024 •
edited

@clinique : can you provide few use cases where this binding is useful compared to actions already provided by the core framework?

Sure. This binding makes it really easier to use Ephemeris information via Items instead of script actions. For beginners it is easier, and Items are first class citizens - this binding provides all that everyone would need to code by himself, directly out of the box.

lolodomo
lolodomo requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review part 1 of 3

...rc/main/java/org/openhab/binding/ephemeris/internal/discovery/EphemerisDiscoveryService.java Outdated Show resolved Hide resolved
...rc/main/java/org/openhab/binding/ephemeris/internal/discovery/EphemerisDiscoveryService.java Outdated Show resolved Hide resolved
...meris/src/main/java/org/openhab/binding/ephemeris/internal/handler/BaseEphemerisHandler.java Outdated Show resolved Hide resolved
...meris/src/main/java/org/openhab/binding/ephemeris/internal/handler/BaseEphemerisHandler.java Outdated Show resolved Hide resolved
...meris/src/main/java/org/openhab/binding/ephemeris/internal/handler/BaseEphemerisHandler.java Outdated Show resolved Hide resolved
...ng.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/DaysetHandler.java Outdated Show resolved Hide resolved
...ng.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/DaysetHandler.java Outdated Show resolved Hide resolved
...ng.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/DaysetHandler.java Outdated Show resolved Hide resolved
...g.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/HolidayHandler.java Outdated Show resolved Hide resolved
...ding.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/FileHandler.java Outdated Show resolved Hide resolved
lolodomo
lolodomo requested changes May 22, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review part 2 of 3

bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
@lolodomo
Copy link
Contributor

Notes for myself:

  • incomplete README to be reviewed
  • Way to produce the OFFLINE message
  • IllegalStateException
  • conf folder read-only or not (mkdir)

lolodomo
lolodomo requested changes May 24, 2024
View reviewed changes
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/thing/thing-types.xml Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/src/main/resources/OH-INF/i18n/ephemeris.properties Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/README.md Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/README.md Outdated Show resolved Hide resolved
bundles/org.openhab.binding.ephemeris/README.md Outdated Show resolved Hide resolved
lolodomo
lolodomo requested changes May 24, 2024
View reviewed changes
...ng.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/DaysetHandler.java Outdated Show resolved Hide resolved
...g.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/WeekendHandler.java Outdated Show resolved Hide resolved
....ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/JollydayHandler.java Outdated Show resolved Hide resolved
....ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/JollydayHandler.java Outdated Show resolved Hide resolved
...ng.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/CustomHandler.java Outdated Show resolved Hide resolved
...ng.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/CustomHandler.java Show resolved Hide resolved
...ng.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/CustomHandler.java Outdated Show resolved Hide resolved
@lolodomo
Copy link
Contributor

I don't know why but build of your branch locally in my PC fails during feature verification:

[INFO] --- karaf-maven-plugin:4.4.5:verify (karaf-feature-verification) @ org.openhab.binding.ephemeris ---
[INFO] Using repositories: https://openhab.jfrog.io/openhab/libs-release@id=openhab-release,https://openhab.jfrog.io/openhab/libs-snapshot@id=openhab-snapshot@noreleases@snapshots,https://repo1.maven.org/maven2@id=central
[WARNING] Feature resolution failed for [openhab-binding-ephemeris/4.2.0.SNAPSHOT]
Message: Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=openhab-binding-ephemeris; type=karaf.feature; version=4.2.0.SNAPSHOT; filter:="(&(osgi.identity=openhab-binding-ephemeris)(type=karaf.feature)(version>=4.2.0.SNAPSHOT))" [caused by: Unable to resolve openhab-binding-ephemeris/4.2.0.SNAPSHOT: missing requirement [openhab-binding-ephemeris/4.2.0.SNAPSHOT] osgi.identity; osgi.identity=openhab-runtime-base; type=karaf.feature [caused by: Unable to resolve openhab-runtime-base/4.2.0.SNAPSHOT: missing requirement [openhab-runtime-base/4.2.0.SNAPSHOT] osgi.identity; osgi.identity=openhab-core-model-item; type=karaf.feature [caused by: Unable to resolve openhab-core-model-item/4.2.0.SNAPSHOT: missing requirement [openhab-core-model-item/4.2.0.SNAPSHOT] osgi.identity; osgi.identity=org.openhab.core.model.item; type=osgi.bundle; version="[4.2.0.202405251345,4.2.0.202405251345]"; resolution:=mandatory [caused by: Unable to resolve org.openhab.core.model.item/4.2.0.202405251345: missing requirement [org.openhab.core.model.item/4.2.0.202405251345] osgi.wiring.bundle; osgi.wiring.bundle=org.eclipse.xtext.common.types; filter:="(osgi.wiring.bundle=org.eclipse.xtext.common.types)" [caused by: Unable to resolve org.eclipse.xtext.common.types/2.35.0.v20240430-1012: missing requirement [org.eclipse.xtext.common.types/2.35.0.v20240430-1012] osgi.wiring.bundle; osgi.wiring.bundle=org.objectweb.asm; bundle-version="[9.7.0,9.8.0)"; filter:="(&(osgi.wiring.bundle=org.objectweb.asm)(bundle-version>=9.7.0)(!(bundle-version>=9.8.0)))"]]]]]
Repositories: {
        file:D:\dev\openhab4\git\openhab-addons\bundles\org.openhab.binding.ephemeris\target/feature/feature.xml
        mvn:org.apache.karaf.features/framework/4.4.5/xml/features
        mvn:org.apache.karaf.features/specs/4.4.5/xml/features
        mvn:org.apache.karaf.features/standard/4.4.5/xml/features
        mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-core/4.2.0-SNAPSHOT/xml/features
        mvn:org.openhab.core.features.karaf/org.openhab.core.features.karaf.openhab-tp/4.2.0-SNAPSHOT/xml/features
        mvn:org.ops4j.pax.web/pax-web-features/8.0.24/xml/features
}
Resources: {
        mvn:com.fasterxml.jackson.core/jackson-annotations/2.17.1
        mvn:com.fasterxml.jackson.core/jackson-core/2.17.1
        mvn:com.fasterxml.jackson.core/jackson-databind/2.17.1
        mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-cbor/2.17.1
        mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-xml/2.17.1
        mvn:com.fasterxml.jackson.dataformat/jackson-dataformat-yaml/2.17.1
        mvn:com.fasterxml.jackson.datatype/jackson-datatype-jsr310/2.17.1
        mvn:com.fasterxml.jackson.jaxrs/jackson-jaxrs-base/2.17.1
        mvn:com.fasterxml.jackson.jaxrs/jackson-jaxrs-json-provider/2.17.1
        mvn:com.fasterxml.jackson.module/jackson-module-jaxb-annotations/2.17.1
        mvn:com.fasterxml.woodstox/woodstox-core/6.5.1
        mvn:com.google.guava/failureaccess/1.0.2
        mvn:com.google.guava/guava/33.1.0-jre
        mvn:com.google.inject/guice/7.0.0
        mvn:com.sun.xml.bind/jaxb-osgi/2.3.8
        mvn:com.thoughtworks.xstream/xstream/1.4.20
        mvn:de.focus-shift/jollyday-core/0.28.1
        mvn:de.focus-shift/jollyday-jackson/0.28.1
        mvn:io.github.classgraph/classgraph/4.8.172
        mvn:io.swagger.core.v3/swagger-annotations/2.2.15
        mvn:io.swagger.core.v3/swagger-core/2.2.15
        mvn:io.swagger.core.v3/swagger-integration/2.2.15
        mvn:io.swagger.core.v3/swagger-jaxrs2/2.2.15
        mvn:io.swagger.core.v3/swagger-models/2.2.15
        mvn:jakarta.annotation/jakarta.annotation-api/2.0.0
        mvn:jakarta.inject/jakarta.inject-api/1.0.5
        mvn:jakarta.inject/jakarta.inject-api/2.0.1
        mvn:jakarta.jws/jakarta.jws-api/2.1.0
        mvn:jakarta.servlet/jakarta.servlet-api/4.0.4
        mvn:jakarta.validation/jakarta.validation-api/2.0.2
        mvn:jakarta.websocket/jakarta.websocket-api/1.1.2
        mvn:jakarta.xml.bind/jakarta.xml.bind-api/2.3.3
        mvn:jakarta.xml.ws/jakarta.xml.ws-api/2.3.3
        mvn:javax.annotation/javax.annotation-api/1.3.2
        mvn:javax.measure/unit-api/2.2
        mvn:javax.servlet/javax.servlet-api/3.1.0
        mvn:net.java.dev.jna/jna-platform/5.14.0
        mvn:net.java.dev.jna/jna/5.14.0
        mvn:org.apache.aries.component-dsl/org.apache.aries.component-dsl.component-dsl/1.2.2
        mvn:org.apache.aries.jax.rs/org.apache.aries.jax.rs.whiteboard/2.0.2
        mvn:org.apache.aries.spec/org.apache.aries.javax.jax.rs-api/1.0.4
        mvn:org.apache.aries.spifly/org.apache.aries.spifly.dynamic.bundle/1.3.7
        mvn:org.apache.commons/commons-lang3/3.14.0
        mvn:org.apache.cxf/cxf-core/3.6.2
        mvn:org.apache.cxf/cxf-rt-frontend-jaxrs/3.6.2
        mvn:org.apache.cxf/cxf-rt-rs-client/3.6.2
        mvn:org.apache.cxf/cxf-rt-rs-sse/3.6.2
        mvn:org.apache.cxf/cxf-rt-security/3.6.2
        mvn:org.apache.cxf/cxf-rt-transports-http/3.6.2
        mvn:org.apache.felix/org.apache.felix.cm.json/1.0.6
        mvn:org.apache.felix/org.apache.felix.configadmin.plugin.interpolation/1.2.8
        mvn:org.apache.felix/org.apache.felix.configadmin/1.9.26
        mvn:org.apache.felix/org.apache.felix.configurator/1.0.16
        mvn:org.apache.felix/org.apache.felix.converter/1.0.14
        mvn:org.apache.felix/org.apache.felix.coordinator/1.0.2
        mvn:org.apache.felix/org.apache.felix.fileinstall/3.7.4
        mvn:org.apache.felix/org.apache.felix.inventory/1.1.0
        mvn:org.apache.felix/org.apache.felix.metatype/1.2.4
        mvn:org.apache.felix/org.apache.felix.scr/2.2.6
        mvn:org.apache.felix/org.apache.felix.webconsole.plugins.ds/2.2.0
        mvn:org.apache.felix/org.apache.felix.webconsole.plugins.event/1.1.8
        mvn:org.apache.karaf.config/org.apache.karaf.config.core/4.4.5
        mvn:org.apache.karaf.features/org.apache.karaf.features.core/4.4.5
        mvn:org.apache.karaf.features/org.apache.karaf.features.extension/4.4.5
        mvn:org.apache.karaf.http/org.apache.karaf.http.core/4.4.5
        mvn:org.apache.karaf.jaas/org.apache.karaf.jaas.boot/4.4.5
        mvn:org.apache.karaf.jaas/org.apache.karaf.jaas.command/4.4.5
        mvn:org.apache.karaf.jaas/org.apache.karaf.jaas.config/4.4.5
        mvn:org.apache.karaf.jaas/org.apache.karaf.jaas.modules/4.4.5
        mvn:org.apache.karaf.kar/org.apache.karaf.kar.core/4.4.5
        mvn:org.apache.karaf.log/org.apache.karaf.log.core/4.4.5
        mvn:org.apache.karaf.scr/org.apache.karaf.scr.management/4.4.5
        mvn:org.apache.karaf.scr/org.apache.karaf.scr.state/4.4.5
        mvn:org.apache.karaf.services/org.apache.karaf.services.eventadmin/4.4.5
        mvn:org.apache.karaf.shell/org.apache.karaf.shell.commands/4.4.5
        mvn:org.apache.karaf.shell/org.apache.karaf.shell.core/4.4.5
        mvn:org.apache.karaf.shell/org.apache.karaf.shell.groovy/4.4.5
        mvn:org.apache.karaf.webconsole/org.apache.karaf.webconsole.http/4.4.5
        mvn:org.apache.karaf.wrapper/org.apache.karaf.wrapper.core/4.4.5
        mvn:org.apache.karaf/org.apache.karaf.event/4.4.5
        mvn:org.apache.servicemix.bundles/org.apache.servicemix.bundles.saaj-impl/1.4.0_2
        mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.activation-api-1.2.1/1.2.1_3
        mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.jaxb-api-2.2/2.9.0
        mvn:org.apache.servicemix.specs/org.apache.servicemix.specs.saaj-api-1.4/1.4_2
        mvn:org.apache.sling/org.apache.sling.commons.johnzon/1.2.16
        mvn:org.apache.ws.xmlschema/xmlschema-core/2.3.1
        mvn:org.apiguardian/apiguardian-api/1.1.2
        mvn:org.bitbucket.b_c/jose4j/0.9.5
        mvn:org.codehaus.woodstox/stax2-api/4.2.2
        mvn:org.eclipse.emf/org.eclipse.emf.common/2.24.0
        mvn:org.eclipse.emf/org.eclipse.emf.ecore.change/2.14.0
        mvn:org.eclipse.emf/org.eclipse.emf.ecore.xmi/2.16.0
        mvn:org.eclipse.emf/org.eclipse.emf.ecore/2.26.0
        mvn:org.eclipse.jetty.alpn/alpn-api/1.1.3.v20160715
        mvn:org.eclipse.jetty.http2/http2-client/9.4.53.v20231009
        mvn:org.eclipse.jetty.http2/http2-common/9.4.53.v20231009
        mvn:org.eclipse.jetty.http2/http2-hpack/9.4.53.v20231009
        mvn:org.eclipse.jetty.http2/http2-http-client-transport/9.4.53.v20231009
        mvn:org.eclipse.jetty.http2/http2-server/9.4.53.v20231009
        mvn:org.eclipse.jetty.websocket/javax-websocket-client-impl/9.4.53.v20231009
        mvn:org.eclipse.jetty.websocket/javax-websocket-server-impl/9.4.53.v20231009
        mvn:org.eclipse.jetty.websocket/websocket-api/9.4.53.v20231009
        mvn:org.eclipse.jetty.websocket/websocket-client/9.4.53.v20231009
        mvn:org.eclipse.jetty.websocket/websocket-common/9.4.53.v20231009
        mvn:org.eclipse.jetty.websocket/websocket-server/9.4.53.v20231009
        mvn:org.eclipse.jetty.websocket/websocket-servlet/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-alpn-client/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-alpn-java-client/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-alpn-java-server/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-alpn-server/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-client/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-continuation/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-http/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-io/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-jaas/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-jmx/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-openid/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-proxy/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-rewrite/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-security/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-server/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-servlet/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-servlets/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-util-ajax/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-util/9.4.53.v20231009
        mvn:org.eclipse.jetty/jetty-xml/9.4.53.v20231009
        mvn:org.eclipse.lsp4j/org.eclipse.lsp4j.jsonrpc/0.22.0
        mvn:org.eclipse.lsp4j/org.eclipse.lsp4j/0.22.0
        mvn:org.eclipse.orbit.bundles/com.google.gson/2.10.1.v20230109-0753
        mvn:org.eclipse.orbit.bundles/org.antlr.runtime/3.2.0.v201101311130
        mvn:org.eclipse.orbit.bundles/org.aopalliance/1.0.0.v201105210816
        mvn:org.eclipse.platform/org.eclipse.equinox.common/3.18.0
        mvn:org.eclipse.platform/org.eclipse.equinox.registry/3.9.0
        mvn:org.eclipse.platform/org.eclipse.equinox.supplement/1.9.0
        mvn:org.eclipse.platform/org.eclipse.osgi/3.18.0
        mvn:org.eclipse.xtend/org.eclipse.xtend.lib.macro/2.35.0.M1
        mvn:org.eclipse.xtend/org.eclipse.xtend.lib/2.35.0.M1
        mvn:org.eclipse.xtext/org.eclipse.xtext.common.types/2.35.0.M1
        mvn:org.eclipse.xtext/org.eclipse.xtext.ide/2.35.0.M1
        mvn:org.eclipse.xtext/org.eclipse.xtext.smap/2.35.0.M1
        mvn:org.eclipse.xtext/org.eclipse.xtext.util/2.35.0.M1
        mvn:org.eclipse.xtext/org.eclipse.xtext.xbase.ide/2.35.0.M1
        mvn:org.eclipse.xtext/org.eclipse.xtext.xbase.lib/2.35.0.M1
        mvn:org.eclipse.xtext/org.eclipse.xtext.xbase/2.35.0.M1
        mvn:org.eclipse.xtext/org.eclipse.xtext/2.35.0.M1
        mvn:org.fusesource.jansi/jansi/2.4.1
        mvn:org.glassfish.hk2/osgi-resource-locator/1.0.3
        mvn:org.javassist/javassist/3.29.2-GA
        mvn:org.jline/jline/3.21.0
        mvn:org.jmdns/jmdns/3.5.9
        mvn:org.jvnet.staxex/stax-ex/1.7.4
        mvn:org.openhab.addons.bundles/org.openhab.binding.ephemeris/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.addon.marketplace.karaf/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.addon.marketplace/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.addon/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.audio/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.auth.jaas/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.auth.oauth2client/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.automation.module.media/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.automation.module.script.rulesupport/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.automation.module.script/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.automation.rest/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.automation/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.config.core/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.config.discovery.addon.process/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.config.discovery.addon/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.config.discovery.mdns/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.config.discovery/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.config.dispatch/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.ephemeris/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.id/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.console.karaf/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.console/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.http.auth/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.http/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.jetty.certificate/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.monitor/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.net/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.audio/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.auth/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.core/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.mdns/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.sitemap/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.sse/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.swagger/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.transform/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.ui/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest.voice/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.rest/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.transport.mdns/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.io.websocket/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.karaf/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.core/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.item.ide/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.item.runtime/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.item/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.lsp/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.persistence.ide/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.persistence.runtime/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.persistence/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.rule.ide/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.rule.runtime/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.rule/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.script.ide/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.script.runtime/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.script/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.sitemap.ide/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.sitemap.runtime/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.sitemap/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.thing.ide/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.thing.runtime/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.thing/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.model.yaml/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.persistence/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.semantics/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.storage.json/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.thing/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.transform/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.ui.icon/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.ui/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core.voice/4.2.0-SNAPSHOT
        mvn:org.openhab.core.bundles/org.openhab.core/4.2.0-SNAPSHOT
        mvn:org.openhab.osgiify/io.methvin.directory-watcher/0.18.0
        mvn:org.openhab.osgiify/si.uom.si-units/2.1
        mvn:org.openhab/base-fixes/1.0.0
        mvn:org.ops4j.pax.logging/pax-logging-api/2.2.6
        mvn:org.ops4j.pax.logging/pax-logging-log4j2/2.2.6
        mvn:org.ops4j.pax.url/pax-url-aether/2.6.14
        mvn:org.ops4j.pax.web/pax-web-api/8.0.24
        mvn:org.ops4j.pax.web/pax-web-compatibility-servlet31/8.0.24
        mvn:org.ops4j.pax.web/pax-web-extender-whiteboard/8.0.24
        mvn:org.ops4j.pax.web/pax-web-jetty/8.0.24
        mvn:org.ops4j.pax.web/pax-web-runtime/8.0.24
        mvn:org.ops4j.pax.web/pax-web-spi/8.0.24
        mvn:org.ops4j.pax.web/pax-web-tomcat-common/8.0.24
        mvn:org.ops4j.pax.web/pax-web-websocket/8.0.24
        mvn:org.osgi/org.osgi.service.component.annotations/1.5.1
        mvn:org.osgi/org.osgi.service.component/1.5.1
        mvn:org.osgi/org.osgi.service.jaxrs/1.0.1
        mvn:org.osgi/org.osgi.util.function/1.2.0
        mvn:org.osgi/org.osgi.util.promise/1.3.0
        mvn:org.ow2.asm/asm-analysis/9.6
        mvn:org.ow2.asm/asm-commons/9.6
        mvn:org.ow2.asm/asm-tree/9.6
        mvn:org.ow2.asm/asm-util/9.6
        mvn:org.ow2.asm/asm/9.6
        mvn:org.threeten/threeten-extra/1.8.0
        mvn:org.yaml/snakeyaml/2.2
        mvn:si.uom/si-quantity/2.1
        mvn:tech.units/indriya/2.2
        mvn:tech.uom.lib/uom-lib-common/2.2
}: openhab-binding-ephemeris/4.2.0.SNAPSHOT
[WARNING] Unable to resolve root: missing requirement [root] osgi.identity; osgi.identity=openhab-binding-ephemeris; type=karaf.feature; version=4.2.0.SNAPSHOT; filter:="(&(osgi.identity=openhab-binding-ephemeris)(type=karaf.feature)(version>=4.2.0.SNAPSHOT))" [caused by: Unable to resolve openhab-binding-ephemeris/4.2.0.SNAPSHOT: missing requirement [openhab-binding-ephemeris/4.2.0.SNAPSHOT] osgi.identity; osgi.identity=openhab-runtime-base; type=karaf.feature [caused by: Unable to resolve openhab-runtime-base/4.2.0.SNAPSHOT: missing requirement [openhab-runtime-base/4.2.0.SNAPSHOT] osgi.identity; osgi.identity=openhab-core-model-item; type=karaf.feature [caused by: Unable to resolve openhab-core-model-item/4.2.0.SNAPSHOT: missing requirement [openhab-core-model-item/4.2.0.SNAPSHOT] osgi.identity; osgi.identity=org.openhab.core.model.item; type=osgi.bundle; version="[4.2.0.202405251345,4.2.0.202405251345]"; resolution:=mandatory [caused by: Unable to resolve org.openhab.core.model.item/4.2.0.202405251345: missing requirement [org.openhab.core.model.item/4.2.0.202405251345] osgi.wiring.bundle; osgi.wiring.bundle=org.eclipse.xtext.common.types; filter:="(osgi.wiring.bundle=org.eclipse.xtext.common.types)" [caused by: Unable to resolve org.eclipse.xtext.common.types/2.35.0.v20240430-1012: missing requirement [org.eclipse.xtext.common.types/2.35.0.v20240430-1012] osgi.wiring.bundle; osgi.wiring.bundle=org.objectweb.asm; bundle-version="[9.7.0,9.8.0)"; filter:="(&(osgi.wiring.bundle=org.objectweb.asm)(bundle-version>=9.7.0)(!(bundle-version>=9.8.0)))"]]]]]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

@clinique
Copy link
Contributor Author

Message: Unable to resolve root: missing requirement [root] osgi.identity

I'm facing the same issue on my side.

@lsiepel
Copy link
Contributor

lsiepel commented May 26, 2024

4.4.5

I expect it to work once you pull changes from upstream. as karaf has been updated to 4.4.6

lolodomo
lolodomo reviewed May 26, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One final question

...ng.ephemeris/src/main/java/org/openhab/binding/ephemeris/internal/handler/CustomHandler.java Outdated
Comment on lines 49 to 50
File file = new File(BINDING_DATA_PATH, config.fileName);
if (file.exists()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: should you also check that !config.fileName.isBlank() ?

Copy link
Contributor Author

@clinique clinique May 26, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It can not hurt

@lolodomo
Copy link
Contributor

4.4.5

I expect it to work once you pull changes from upstream. as karaf has been updated to 4.4.6

Yes, please rebase your branch (merge the current version of main branch in your branch).

@clinique
[ephemeris] Initial commit of the ephemeris binding
fcf1b6b 
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@clinique
Enhancing
3aab917 
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@clinique
Added Autodiscovery of Holiday and Weekend
fdbcf5d 
Added Description provider for Holiday title channels
Added Switches for holiday-today and holiday-tomorrow

Signed-off-by: clinique <gael@lhopital.org>
@clinique
Correcting some labels
e22ce87 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Starting documentation
ffa89da 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Correcting SAT report
5a0fc5a 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Adding today and tomorrow event to file.
044578b 
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@clinique
[ephemeris] Initial commit of the ephemeris binding
bd99f6b 
Rebasing pom.xml

Signed-off-by: gael@lhopital.org <gael@lhopital.org>
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Restoring pom.xml + my binding
d373c03 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
spotless on pom
2f8c64e 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Code review n°1
7f23d91 
Signed-off-by: gael@lhopital.org <gael@lhopital.org>
@clinique
Code review n° 2
93fe641 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Removed '*' in imports
b1ef2a9 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Code review n°3
400f66e 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@clinique
Code review n°4
e54d2b6 
Signed-off-by: clinique <gael@lhopital.org>
@clinique
Rebased + code review n°5
9d7cb3a 
Restoring pom.xml + my binding

Signed-off-by: Gaël L'hopital <gael@lhopital.org>
@lolodomo
Copy link
Contributor

lolodomo commented May 26, 2024 •
edited

You forgot to resolve conflicts in pom.xml. this file is now invalid.

@clinique
Restoring pom.xml
c5c4680 
Signed-off-by: Gaël L'hopital <gael@lhopital.org>
lolodomo
lolodomo approved these changes May 26, 2024
View reviewed changes
Copy link
Contributor

@lolodomo lolodomo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you for contributing this new binding.

@lolodomo lolodomo merged commit bae5b0c into openhab:main May 26, 2024
5 checks passed
@lolodomo lolodomo added this to the 4.2 milestone May 26, 2024
@clinique clinique deleted the ephemeris_binding branch May 26, 2024 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lolodomo lolodomo lolodomo approved these changes

Assignees

@clinique clinique

Labels
new binding If someone has started to work on a binding. For a new binding PR.
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@clinique @lsiepel @lolodomo @jlaur