Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[persistence.jpa] Upgrade openjpa and derby #16591

Merged
merged 1 commit into from
May 28, 2024

Conversation

holgerfriedrich
Copy link
Member

@holgerfriedrich holgerfriedrich commented Mar 28, 2024

This updates all base libraries of persistence.java. Goal is to support compiling and running with Java 21 (currently we compile this directory with target release Java 17).

  • Upgrade openjpa from 3.2.2 to 4.0.0
  • Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release)
  • Migrate javax.el to jakarta.el-api 6.0.0-RC1
  • Revert workaround for Java 21, [persistence.jpa] Pin to Java 17 #16612

Note that Derby 10.16.x.x is the last release built for Java 17. It is still affected by CVE-2022-46337. Using version 10.17.x.x which contains a fix is not yet possible until we drop Java 17 support. Derby project did not release fixed version compiled for Java 17.

As I do not use this binding, I need help testing this version. Unfortunately, the binding does not contain test cases.

Refs: openhab/openhab-distro#1590

@holgerfriedrich holgerfriedrich added enhancement An enhancement or new feature for an existing add-on additional testing preferred The change works for the pull request author. A test from someone else is preferred though. labels Mar 28, 2024
@holgerfriedrich holgerfriedrich requested a review from a team as a code owner March 28, 2024 21:41
@lsiepel
Copy link
Contributor

lsiepel commented Apr 28, 2024

@holgerfriedrich maybe you can build a KAR and post it in the community forums, so someone can test it? I don't know anyone who is actively using it. I also couldn't find anyone that raised an issue lately.

Copy link
Contributor

@lsiepel lsiepel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's wait for some test results or merge it and get some live results as i don't expect anyone available to test it prior to a (milestone) release.

Support Java 21

- Upgrade openjpa from 3.2.2 to 4.0.0
- Upgrade derby from 10.14.2.0 to 10.16.1.1 (last Java 17 release)
- Migrate javax.el to jakarta.el-api 6.0.0-RC1
- Revert workaround for Java 21, openhab#16612

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
@lsiepel lsiepel merged commit dcd7783 into openhab:main May 28, 2024
5 checks passed
@lsiepel lsiepel added this to the 4.2 milestone May 28, 2024
@lsiepel
Copy link
Contributor

lsiepel commented May 28, 2024

As i don't expect tests from here. Let's see what some milage on snapshot / next milestone brings before next stable. It would be fairly easy to revert if an unexpected issue shows up.

@holgerfriedrich holgerfriedrich deleted the pr-jpa branch May 28, 2024 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
additional testing preferred The change works for the pull request author. A test from someone else is preferred though. enhancement An enhancement or new feature for an existing add-on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants