[emotiva] Initial contribution #16499

espenaf · 2024-03-07T21:33:05Z

This PR adds support for Emotiva Audio Corporation AV processors based on the Emotiva Network Remote Control protocol. Discovery is supported.

Binding has only been tested with an XMC-2, so please test and give feedback for other devices.

Has support for all Emotiva notification types in version 2.0 and 3.0 of the protocol, and adds support for almost all commands, has support for Zone 2 controls, browsing and controlling the menu and using the radio tuner.

openhab-bot · 2024-03-07T22:00:27Z

This pull request has been mentioned on openHAB Community. There might be relevant details there:

https://community.openhab.org/t/emotiva-av-processor-binding/154406/1

mlobstein · 2024-03-09T01:24:20Z

The build is failing because your commit it not signed. See here for instructions to fix it: https://github.com/openhab/openhab-addons/pull/16499/checks?check_run_id=22412921872

bundles/org.openhab.binding.anel/src/main/resources/OH-INF/config/config.xml

...inding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaCommandHandler.java

austvik · 2024-04-01T10:14:48Z

...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java

+                        "@text/message.processor.connection.failed");
+                disconnect();
+                scheduleConnectRetry(retryConnectInMinutes);
+            }


Thinking out loud: could (some of) this status updating be moved to handleStatusUpdate()?

Not sure, the connection method is synchronized and try to make sure the connection is either working or we need to schedule a retry. Suggestions are welcome.

Regarding the ThingStatus, it is a common practice to:

In initialize()

Set updateStatus(ThingStatus.UNKNOWN); at the start

Check configuration and set ThingStatus with details if it is not valid

End with a scheduled task (e.g. updateTask()) that updates the thing state and channels

In updateTask()

Check if connection is authenticated and continue or get authenticated and set ThingStatus

Get data to update channels, set ThingStatus on error.

Not covering all cases and when applied to this binding it might not suit 100%.

Updated initialize() with status setting and checking of port and ipaddress to the device. As there is no authentication here, I did not do anything around th updateTask().

...ding.emotiva/src/main/java/org/openhab/binding/emotiva/internal/EmotivaProcessorHandler.java

...tiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaControlCommands.java

...ing.emotiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaDataType.java

bundles/org.openhab.binding.emotiva/src/main/resources/OH-INF/config/config.xml

lsiepel

Thanks for this contribution. Looked at all except the key controller/handlers, will do in a next round.
For each comment, try to check if it can also apply to other parts of the code.

Please check that al SAT errors are fxied and the build comes without any warnings.

bundles/org.openhab.binding.emotiva/src/main/resources/OH-INF/thing/thing-types.xml

bundles/org.openhab.binding.emotiva/src/main/resources/OH-INF/addon/addon.xml

...otiva/src/main/java/org/openhab/binding/emotiva/internal/protocol/EmotivaControlRequest.java

...va/src/main/java/org/openhab/binding/emotiva/internal/discovery/EmotivaDiscoveryService.java

lsiepel

^^^

Signed-off-by: Espen Fossen <espenaf@junta.no>

* Renamed all channels to use - instead of _ * Adding state for a number of channels * Start using i18n translations * Cleanups and fixes Signed-off-by: Espen Fossen <espenaf@junta.no>

* Wildcard for static imports. * Removed Norwegian translation. * Removed empty lines. * Small fixes. Signed-off-by: Espen Fossen <espenaf@junta.no>

* Discovery method * Model and revisions as properties * Rename keep-alive to last-seen Signed-off-by: Espen Fossen <espenaf@junta.no>

Signed-off-by: Espen Fossen <espenaf@junta.no>

lsiepel · 2024-05-26T07:38:30Z

While waiting for emotiva to respons to the question about an oiption list, there are some issues to fix.
Can you fix the SAT issues and build warnings. (see
https://github.com/openhab/openhab-addons/actions/runs/9237265388/artifacts/1537689743 )
Some comment about previous review is open: #16499 (comment)

After these are fixed i need one last review round.

* Fix SAT issues * Add config check and set to UNKNOWN on initialize Signed-off-by: Espen Fossen <espenaf@junta.no>

* Rewrite tests from assertj to junit/mockito. Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf · 2024-05-26T22:02:00Z

While waiting for emotiva to respons to the question about an oiption list, there are some issues to fix. Can you fix the SAT issues and build warnings. (see https://github.com/openhab/openhab-addons/actions/runs/9237265388/artifacts/1537689743 ) Some comment about previous review is open: #16499 (comment)

After these are fixed i need one last review round.

Pushed new changes that fixes all the SAT issues.

Signed-off-by: Espen Fossen <espenaf@junta.no>

* Added catch of InterruptedIOException * Move logging of message content to trace Signed-off-by: Espen Fossen <espenaf@junta.no>

lsiepel · 2024-05-28T20:12:38Z

While waiting for emotiva to respons to the question about an oiption list, there are some issues to fix. Can you fix the SAT issues and build warnings. (see https://github.com/openhab/openhab-addons/actions/runs/9237265388/artifacts/1537689743 ) Some comment about previous review is open: #16499 (comment)
After these are fixed i need one last review round.

Pushed new changes that fixes all the SAT issues.

Thanks, Another step forward. There are 35 compile warnings, can you also look into those.

Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf · 2024-05-28T22:55:01Z

While waiting for emotiva to respons to the question about an oiption list, there are some issues to fix. Can you fix the SAT issues and build warnings. (see https://github.com/openhab/openhab-addons/actions/runs/9237265388/artifacts/1537689743 ) Some comment about previous review is open: #16499 (comment)
After these are fixed i need one last review round.

Pushed new changes that fixes all the SAT issues.

Thanks, Another step forward. There are 35 compile warnings, can you also look into those.

Now those have also been fixed.

Communication is established with Emotiva, just waiting on word from the people at Engineering.

espenaf force-pushed the emotiva branch from 6af6918 to 2ed328d Compare March 7, 2024 21:44

mlobstein added the new binding If someone has started to work on a binding. For a new binding PR. label Mar 9, 2024

espenaf force-pushed the emotiva branch 3 times, most recently from eca824b to e3162e3 Compare March 12, 2024 21:52

espenaf force-pushed the emotiva branch from e3162e3 to a14d23e Compare March 18, 2024 11:31

espenaf force-pushed the emotiva branch 2 times, most recently from 3793c64 to 969b223 Compare March 31, 2024 20:43

austvik reviewed Apr 1, 2024

View reviewed changes

bundles/org.openhab.binding.anel/src/main/resources/OH-INF/config/config.xml Outdated Show resolved Hide resolved

austvik reviewed Apr 1, 2024

View reviewed changes

espenaf force-pushed the emotiva branch from 969b223 to bbeb0f6 Compare April 1, 2024 13:33

espenaf force-pushed the emotiva branch 3 times, most recently from bf10246 to 612fde5 Compare April 30, 2024 16:47

espenaf changed the title ~~[emotiva][WIP] Initial contribution~~ [emotiva] Initial contribution Apr 30, 2024

espenaf marked this pull request as ready for review April 30, 2024 16:53

espenaf requested a review from a team as a code owner April 30, 2024 16:53

espenaf force-pushed the emotiva branch 2 times, most recently from 10d3e3c to ec88727 Compare April 30, 2024 20:16

lsiepel reviewed May 10, 2024

View reviewed changes

lsiepel requested changes May 20, 2024

View reviewed changes

espenaf force-pushed the emotiva branch from ec88727 to 8802220 Compare May 23, 2024 22:19

espenaf added 3 commits May 24, 2024 23:23

[emotiva] Initial contribution

6aa47bb

Signed-off-by: Espen Fossen <espenaf@junta.no>

[emotiva] Code review round 1:

6fc0ef4

* Renamed all channels to use - instead of _ * Adding state for a number of channels * Start using i18n translations * Cleanups and fixes Signed-off-by: Espen Fossen <espenaf@junta.no>

Code review round 2:

97179d6

* Wildcard for static imports. * Removed Norwegian translation. * Removed empty lines. * Small fixes. Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf force-pushed the emotiva branch from 11b4e17 to 4187a31 Compare May 24, 2024 21:23

[emotiva] Code review round 3:

69f0643

* Discovery method * Model and revisions as properties * Rename keep-alive to last-seen Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf force-pushed the emotiva branch from ebd17ae to 69f0643 Compare May 25, 2024 08:37

[emotiva] Remove keep-alive/last-seen channel.

1fdacb8

Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf force-pushed the emotiva branch from b65d293 to 1fdacb8 Compare May 25, 2024 18:03

espenaf added 2 commits May 26, 2024 23:03

[emotiva] Code review round 4

bad5b9f

* Fix SAT issues * Add config check and set to UNKNOWN on initialize Signed-off-by: Espen Fossen <espenaf@junta.no>

[emotiva] Code review round 5

535e962

* Rewrite tests from assertj to junit/mockito. Signed-off-by: Espen Fossen <espenaf@junta.no>

espenaf added 2 commits May 27, 2024 23:45

[emotiva] Fix correct channel to step frequencies

7c5c3a8

Signed-off-by: Espen Fossen <espenaf@junta.no>

[emotiva] Fixes after going through review checklist

a006dfc

* Added catch of InterruptedIOException * Move logging of message content to trace Signed-off-by: Espen Fossen <espenaf@junta.no>

[emotiva] Fixed all compiler warnings.

29896c4

Signed-off-by: Espen Fossen <espenaf@junta.no>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[emotiva] Initial contribution #16499

[emotiva] Initial contribution #16499

espenaf commented Mar 7, 2024 •

edited

openhab-bot commented Mar 7, 2024

mlobstein commented Mar 9, 2024

austvik Apr 1, 2024

espenaf Apr 30, 2024

lsiepel May 20, 2024

espenaf May 26, 2024 •

edited

lsiepel left a comment •

edited

lsiepel left a comment

lsiepel commented May 26, 2024

espenaf commented May 26, 2024

lsiepel commented May 28, 2024

espenaf commented May 28, 2024

[emotiva] Initial contribution #16499

Are you sure you want to change the base?

[emotiva] Initial contribution #16499

Conversation

espenaf commented Mar 7, 2024 • edited

openhab-bot commented Mar 7, 2024

mlobstein commented Mar 9, 2024

austvik Apr 1, 2024

Choose a reason for hiding this comment

espenaf Apr 30, 2024

Choose a reason for hiding this comment

lsiepel May 20, 2024

Choose a reason for hiding this comment

espenaf May 26, 2024 • edited

Choose a reason for hiding this comment

lsiepel left a comment • edited

Choose a reason for hiding this comment

lsiepel left a comment

Choose a reason for hiding this comment

lsiepel commented May 26, 2024

espenaf commented May 26, 2024

lsiepel commented May 28, 2024

espenaf commented May 28, 2024

espenaf commented Mar 7, 2024 •

edited

espenaf May 26, 2024 •

edited

lsiepel left a comment •

edited