Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build(deps-dev): reinstate wildcard for webpack #1521

Merged
merged 2 commits into from
Apr 8, 2022
Merged

build(deps-dev): reinstate wildcard for webpack #1521

merged 2 commits into from
Apr 8, 2022

Conversation

LoneRifle
Copy link
Contributor

@LoneRifle LoneRifle commented Apr 8, 2022 •
edited

Problem and Solution

webpack issues with Chakra seem to have resolved with webpack/webpack#15634, so reinstate wildcard

@LoneRifle LoneRifle requested a review from zxt-tzx April 8, 2022 00:21
@LoneRifle LoneRifle added this to Review In progress in AskGov Product Development Kanban via automation Apr 8, 2022
@zxt-tzx
Copy link
Contributor

zxt-tzx commented Apr 8, 2022

updated the package-lock.json, otherwise lgtm

@LoneRifle LoneRifle merged commit 4422c8d into develop Apr 8, 2022
AskGov Product Development Kanban automation moved this from Review In progress to Done Apr 8, 2022
@LoneRifle LoneRifle deleted the build/deps-dev/webpack-5.72 branch April 8, 2022 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zxt-tzx zxt-tzx zxt-tzx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
AskGov Product Development Kanban
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LoneRifle @zxt-tzx