feat: migrate from CRA4 to Vite, Storybook to v8, jest to Vitest #7285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 24, 2024
karrui
changed the title
|
@KenLSM see chromatic useful. will ensure the migration has 0 frontend changes!!! |
karrui
changed the title
karrui
changed the title
|
@justynoh this PR officially has no regressions hehehehe |
|
@justynoh added datadog chunking back to the pipeline. Can push to staging to try? |
not v9 for now since lots of breaking changes plugin prettier also v4 for now, v5 breaks due to
since we are still on CRA4
# Conflicts: # .eslintrc
so react-email templates has no type errors when rendering on the server
v2 requires more changes, not worth it for now
actually good to snapshot full page instead of just fixed pages
hypothesis is that multiple toasts are rendering???
does not seem to be needed now that we use vite
karrui
force-pushed
the
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
branch
from
0a96443
to
9f75cd7
Compare
karrui
force-pushed
the
04-23-feat_add_initial_vite_config_and_new_eslint_rules
branch
from
2c7a9e4
to
9177241
Compare
karrui
commented
May 2, 2024
frontend/package.json
Outdated
| "test": "cross-env SKIP_PREFLIGHT_CHECK=true craco test --silent", | ||
| "start": "vite", | ||
| "build": "vite build", | ||
| "serve": "vite preview", |
There was a problem hiding this comment.
can remove don't add confusion
karrui
commented
May 2, 2024
frontend/package.json
Outdated
| "start": "vite", | ||
| "build": "vite build", | ||
| "serve": "vite preview", | ||
| "test": "cross-env SKIP_PREFLIGHT_CHECK=true vitest", | ||
| "eject": "react-scripts eject", |
karrui
commented
May 2, 2024
frontend/package.json
Outdated
| "eject": "react-scripts eject", | ||
| "storybook": "NODE_OPTIONS=--openssl-legacy-provider start-storybook -p 6006", | ||
| "build-storybook": "NODE_OPTIONS=--openssl-legacy-provider build-storybook", | ||
| "storybook": "NODE_OPTIONS=--openssl-legacy-provider storybook dev -p 6006", |
There was a problem hiding this comment.
no need node options anymore
Base automatically changed from
04-23-fix_remove_erroneous_react_type_pkg_install_on_root
to
04-23-feat_upgrade_prettier_to_v3
May 15, 2024 12:34
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the frontend toolchain from CRA4 to Vite.
Generally everything seems to be working fine, including decryption workers.
Requires a bunch of changes that has to be performed all at the same time:
TODO: