Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: release v5.2.0 #1381

Merged
merged 29 commits into from Mar 16, 2021
Merged

build: release v5.2.0 #1381

merged 29 commits into from Mar 16, 2021
+633 −615

Conversation

mantariksh
Copy link
Contributor

Improved

  • feat: use isPossible for phone number validation #1317
  • test: jest tests for mobile number validation, including signature validation #1349
  • build: remove unused await-to-js #1345
  • feat: remove status key in ApplicationError class #1338

Dependency upgrades

  • fix(deps): bump @opengovsg/spcp-auth-client from 1.4.2 to 1.4.3 #1370
  • chore(deps-dev): bump @types/nodemailer from 6.4.0 to 6.4.1 #1373
  • chore(deps-dev): bump mockdate from 3.0.2 to 3.0.3 #1374
  • chore(deps-dev): bump eslint from 7.21.0 to 7.22.0 #1375
  • fix(deps): bump convict-format-with-validator from 6.0.0 to 6.0.1 #1369
  • chore(deps-dev): bump @types/convict from 6.0.0 to 6.0.1 #1371
  • chore(deps-dev): bump eslint-plugin-jest from 24.2.1 to 24.3.1 #1368
  • fix(deps): bump aws-sdk from 2.861.0 to 2.863.0 #1367
  • chore(deps-dev): bump ngrok from 3.4.0 to 3.4.1 #1363
  • fix(deps): bump connect-mongo from 4.3.1 to 4.4.0 #1357
  • fix(deps): bump @sentry/browser from 6.2.1 to 6.2.2 #1358
  • chore(deps-dev): bump @types/node from 14.14.33 to 14.14.34 #1364
  • chore(deps-dev): bump @opengovsg/mockpass from 2.6.5 to 2.6.6 #1359
  • fix(deps): bump @sentry/integrations from 6.2.1 to 6.2.2 #1360
  • chore(deps-dev): bump @babel/core from 7.13.8 to 7.13.10 #1354
  • fix(deps): bump @opengovsg/spcp-auth-client from 1.4.0 to 1.4.2 #1353
  • chore(deps-dev): bump @babel/plugin-transform-runtime #1331
  • fix(deps): bump libphonenumber-js from 1.9.12 to 1.9.13 #1352
  • chore(deps-dev): bump eslint-plugin-jest from 24.1.9 to 24.2.1 #1351
  • fix(deps): bump connect-mongo from 4.2.2 to 4.3.1 #1346
  • fix(deps): bump aws-sdk from 2.859.0 to 2.861.0 #1347
  • chore(deps-dev): bump @typescript-eslint/eslint-plugin #1336
  • chore(deps-dev): bump @babel/preset-env from 7.13.9 to 7.13.10 #1333

liangyuanruo and others added 29 commits March 10, 2021 17:03
@liangyuanruo
Merge pull request #1341 from opengovsg/release-5.1.0
d17550d 
build: merge release 5.1.0 into develop
@karrui
feat: remove status key in ApplicationError class (#1338)
9cb552b 
* Also updates meta key in ApplicationError constructor to unknown type
@liangyuanruo
build: remove unused await-to-js (#1345)
aa0fea0
@dependabot
chore(deps-dev): bump @babel/preset-env from 7.13.9 to 7.13.10 (#1333)
f12b8b3 
Bumps [@babel/preset-env](https://github.com/babel/babel/tree/HEAD/packages/babel-preset-env) from 7.13.9 to 7.13.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.10/packages/babel-preset-env)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @typescript-eslint/eslint-plugin (#1336)
1179b1b 
Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 4.16.1 to 4.17.0.
- [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases)
- [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/master/packages/eslint-plugin/CHANGELOG.md)
- [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v4.17.0/packages/eslint-plugin)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.859.0 to 2.861.0 (#1347)
f9b4c8d 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.859.0 to 2.861.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.859.0...v2.861.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot @mantariksh
fix(deps): bump connect-mongo from 4.2.2 to 4.3.1 (#1346)
49d9530 
* fix(deps): bump connect-mongo from 4.2.2 to 4.3.1

Bumps [connect-mongo](https://github.com/jdesboeufs/connect-mongo) from 4.2.2 to 4.3.1.
- [Release notes](https://github.com/jdesboeufs/connect-mongo/releases)
- [Changelog](https://github.com/jdesboeufs/connect-mongo/blob/master/CHANGELOG.md)
- [Commits](jdesboeufs/connect-mongo@v4.2.2...v4.3.1)

Signed-off-by: dependabot[bot] <support@github.com>

* ref: use new client option

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Antariksh <antarikshmahajan@gmail.com>
@dependabot
chore(deps-dev): bump eslint-plugin-jest from 24.1.9 to 24.2.1 (#1351)
f33bf68 
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 24.1.9 to 24.2.1.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v24.1.9...v24.2.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump libphonenumber-js from 1.9.12 to 1.9.13 (#1352)
eeb9b28 
Bumps [libphonenumber-js](https://gitlab.com/catamphetamine/libphonenumber-js) from 1.9.12 to 1.9.13.
- [Release notes](https://gitlab.com/catamphetamine/libphonenumber-js/tags)
- [Changelog](https://gitlab.com/catamphetamine/libphonenumber-js/blob/master/CHANGELOG.md)
- [Commits](https://gitlab.com/catamphetamine/libphonenumber-js/commits/master)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/plugin-transform-runtime (#1331)
d09e819 
Bumps [@babel/plugin-transform-runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-plugin-transform-runtime) from 7.13.9 to 7.13.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.10/packages/babel-plugin-transform-runtime)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @opengovsg/spcp-auth-client from 1.4.0 to 1.4.2 (#1353)
e6f58a9 
Bumps [@opengovsg/spcp-auth-client](https://github.com/opengovsg/spcp-auth-client) from 1.4.0 to 1.4.2.
- [Release notes](https://github.com/opengovsg/spcp-auth-client/releases)
- [Commits](opengovsg/spcp-auth-client@v1.4.0...v1.4.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @babel/core from 7.13.8 to 7.13.10 (#1354)
8acae85 
Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.13.8 to 7.13.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.13.10/packages/babel-core)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/integrations from 6.2.1 to 6.2.2 (#1360)
f5ad53a 
Bumps [@sentry/integrations](https://github.com/getsentry/sentry-javascript) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.2.1...6.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @opengovsg/mockpass from 2.6.5 to 2.6.6 (#1359)
397cf03 
Bumps [@opengovsg/mockpass](https://github.com/opengovsg/mockpass) from 2.6.5 to 2.6.6.
- [Release notes](https://github.com/opengovsg/mockpass/releases)
- [Commits](opengovsg/mockpass@v2.6.5...v2.6.6)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tshuli
test: jest tests for mobile number validation, including signature va…
1083aa1 
…lidation (#1349)
@dependabot
chore(deps-dev): bump @types/node from 14.14.33 to 14.14.34 (#1364)
9d07aa9 
Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 14.14.33 to 14.14.34.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @sentry/browser from 6.2.1 to 6.2.2 (#1358)
80d0bf0 
Bumps [@sentry/browser](https://github.com/getsentry/sentry-javascript) from 6.2.1 to 6.2.2.
- [Release notes](https://github.com/getsentry/sentry-javascript/releases)
- [Changelog](https://github.com/getsentry/sentry-javascript/blob/master/CHANGELOG.md)
- [Commits](getsentry/sentry-javascript@6.2.1...6.2.2)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump connect-mongo from 4.3.1 to 4.4.0 (#1357)
f60fdba 
Bumps [connect-mongo](https://github.com/jdesboeufs/connect-mongo) from 4.3.1 to 4.4.0.
- [Release notes](https://github.com/jdesboeufs/connect-mongo/releases)
- [Changelog](https://github.com/jdesboeufs/connect-mongo/blob/master/CHANGELOG.md)
- [Commits](jdesboeufs/connect-mongo@v4.3.1...v4.4.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump ngrok from 3.4.0 to 3.4.1 (#1363)
ad23e07 
Bumps [ngrok](https://github.com/bubenshchykov/ngrok) from 3.4.0 to 3.4.1.
- [Release notes](https://github.com/bubenshchykov/ngrok/releases)
- [Changelog](https://github.com/bubenshchykov/ngrok/blob/master/CHANGELOG.md)
- [Commits](bubenshchykov/ngrok@v3.4.0...v3.4.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump aws-sdk from 2.861.0 to 2.863.0 (#1367)
99fc54d 
Bumps [aws-sdk](https://github.com/aws/aws-sdk-js) from 2.861.0 to 2.863.0.
- [Release notes](https://github.com/aws/aws-sdk-js/releases)
- [Changelog](https://github.com/aws/aws-sdk-js/blob/master/CHANGELOG.md)
- [Commits](aws/aws-sdk-js@v2.861.0...v2.863.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump eslint-plugin-jest from 24.2.1 to 24.3.1 (#1368)
d58060a 
Bumps [eslint-plugin-jest](https://github.com/jest-community/eslint-plugin-jest) from 24.2.1 to 24.3.1.
- [Release notes](https://github.com/jest-community/eslint-plugin-jest/releases)
- [Changelog](https://github.com/jest-community/eslint-plugin-jest/blob/main/CHANGELOG.md)
- [Commits](jest-community/eslint-plugin-jest@v24.2.1...v24.3.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/convict from 6.0.0 to 6.0.1 (#1371)
ce47219 
Bumps [@types/convict](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/convict) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/convict)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump convict-format-with-validator from 6.0.0 to 6.0.1 (#1369
f01d9cb 
)

Bumps [convict-format-with-validator](https://github.com/mozilla/node-convict) from 6.0.0 to 6.0.1.
- [Release notes](https://github.com/mozilla/node-convict/releases)
- [Changelog](https://github.com/mozilla/node-convict/blob/master/CHANGELOG.md)
- [Commits](mozilla/node-convict@v6.0.0...v6.0.1)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@tshuli
feat: use isPossible for phone number validation (#1317)
bd812c2
@dependabot
chore(deps-dev): bump eslint from 7.21.0 to 7.22.0 (#1375)
f64b07c 
Bumps [eslint](https://github.com/eslint/eslint) from 7.21.0 to 7.22.0.
- [Release notes](https://github.com/eslint/eslint/releases)
- [Changelog](https://github.com/eslint/eslint/blob/master/CHANGELOG.md)
- [Commits](eslint/eslint@v7.21.0...v7.22.0)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump mockdate from 3.0.2 to 3.0.3 (#1374)
c198880 
Bumps [mockdate](https://github.com/boblauer/MockDate) from 3.0.2 to 3.0.3.
- [Release notes](https://github.com/boblauer/MockDate/releases)
- [Changelog](https://github.com/boblauer/MockDate/blob/master/CHANGELOG.md)
- [Commits](boblauer/MockDate@v3.0.2...v3.0.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
chore(deps-dev): bump @types/nodemailer from 6.4.0 to 6.4.1 (#1373)
eec0262 
Bumps [@types/nodemailer](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/nodemailer) from 6.4.0 to 6.4.1.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/nodemailer)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@dependabot
fix(deps): bump @opengovsg/spcp-auth-client from 1.4.2 to 1.4.3 (#1370)
ef6bd4c 
Bumps [@opengovsg/spcp-auth-client](https://github.com/opengovsg/spcp-auth-client) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/opengovsg/spcp-auth-client/releases)
- [Commits](opengovsg/spcp-auth-client@v1.4.2...v1.4.3)

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@mantariksh
chore: bump version to 5.2.0
0eca821
@mantariksh
Copy link
Contributor Author

mantariksh commented Mar 16, 2021 •
edited

@mantariksh

Tests

Verified SMS

  • Create verified SMS field. Check that SMS can still be sent and received for valid Singapore number.

@mantariksh
Copy link
Contributor Author

mantariksh commented Mar 16, 2021 •
edited

@mantariksh

Tests

IE11 + intranet

  • Create email mode form with all fields and custom start/end page. Activate and submit form. Check that you can receive responses in your intranet inbox.
  • Collaborators can be added in email mode.
  • Create storage mode form with all fields and custom start/end page. Activate and submit form.
  • Response CSV can be downloaded for storage mode.
  • Responses can be viewed in Data tab in storage mode.
  • Attachments for individual fields can be downloaded from Data tab in storage mode.
  • Attachment ZIP for submission can be downloaded from Data tab in storage mode.
  • Submission IDs can be filtered in storage mode.
  • Collaborators can be added and their collaborating rights edited in storage mode.

tshuli
tshuli approved these changes Mar 16, 2021
View reviewed changes
Copy link
Contributor

@tshuli tshuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@mantariksh mantariksh merged commit 6074186 into release Mar 16, 2021
@karrui karrui mentioned this pull request Mar 23, 2021
Merged
@karrui karrui deleted the release-v5.2.0 branch April 21, 2021 02:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tshuli tshuli tshuli approved these changes

@karrui karrui Awaiting requested review from karrui

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@mantariksh @tshuli @liangyuanruo @karrui