Merge pull request #1337 from opengovsg/release-5.1.0

build: release 5.1.0
opengovsg · Mar 10, 2021 · ffa5606 · ffa5606
2 parents 3957107 + 8bb5ad1
commit ffa5606
Show file tree

Hide file tree

Showing 117 changed files with 7,812 additions and 3,050 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -22,9 +22,14 @@
         "ecmaFeatures": {
           "modules": true
         },
-        "project": "./tsconfig.json"
+        "project": "tsconfig.json"
       },
-      "plugins": ["@typescript-eslint", "import", "simple-import-sort", "typesafe"],
+      "plugins": [
+        "@typescript-eslint",
+        "import",
+        "simple-import-sort",
+        "typesafe"
+      ],
       "extends": ["plugin:@typescript-eslint/recommended"],
       "rules": {
         // Rules for auto sort of imports

diff --git a/.husky/.gitignore b/.husky/.gitignore
@@ -0,0 +1 @@
+_
diff --git a/.husky/pre-commit b/.husky/pre-commit
@@ -0,0 +1,4 @@
+#!/bin/sh
+. "$(dirname "$0")/_/husky.sh"
+
+npx lint-staged && sh secrets-check.sh
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -4,13 +4,87 @@ All notable changes to this project will be documented in this file. Dates are d
 
 Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 
-#### [v5.0.4](https://github.com/opengovsg/FormSG/compare/v5.0.1...v5.0.4)
-
+#### [v5.1.0](https://github.com/opengovsg/FormSG/compare/v4.59.1...v5.1.0)
+
+- chore(deps-dev): bump @types/node from 14.14.32 to 14.14.33 [`#1326`](https://github.com/opengovsg/FormSG/pull/1326)
+- fix(deps): bump @babel/runtime from 7.13.9 to 7.13.10 [`#1327`](https://github.com/opengovsg/FormSG/pull/1327)
+- chore(deps-dev): bump @typescript-eslint/parser from 4.16.1 to 4.17.0 [`#1328`](https://github.com/opengovsg/FormSG/pull/1328)
+- feat(frontend): write FieldVerificationService in TypeScript [`#1259`](https://github.com/opengovsg/FormSG/pull/1259)
+- fix(deps): bump aws-sdk from 2.858.0 to 2.859.0 [`#1329`](https://github.com/opengovsg/FormSG/pull/1329)
+- refactor: stop replacing spaces in SAML artifact [`#1325`](https://github.com/opengovsg/FormSG/pull/1325)
+- feat: remove MyInfo error_description support [`#1323`](https://github.com/opengovsg/FormSG/pull/1323)
+- refactor/logic: Validate webpack upgrades are ready for React migration [`#1201`](https://github.com/opengovsg/FormSG/pull/1201)
+- fix: put back link for email reliability [`#1324`](https://github.com/opengovsg/FormSG/pull/1324)
+- chore(deps-dev): bump stylelint-config-standard from 20.0.0 to 21.0.0 [`#1321`](https://github.com/opengovsg/FormSG/pull/1321)
+- chore(deps-dev): bump eslint-plugin-jest from 24.1.8 to 24.1.9 [`#1319`](https://github.com/opengovsg/FormSG/pull/1319)
+- chore(deps-dev): bump mongodb-memory-server-core from 6.9.3 to 6.9.6 [`#1318`](https://github.com/opengovsg/FormSG/pull/1318)
+- test: add tests for new MyInfo functionality [`#1313`](https://github.com/opengovsg/FormSG/pull/1313)
+- refactor: remove try-catch from submissions pipeline [`#1315`](https://github.com/opengovsg/FormSG/pull/1315)
+- feat: remove MyInfo support from SPCP endpoints [`#1314`](https://github.com/opengovsg/FormSG/pull/1314)
+- feat: upgrade to beta version of myinfo-gov-client [`#1311`](https://github.com/opengovsg/FormSG/pull/1311)
+- refactor: encapsulate parsed responses (part 1) [`#1140`](https://github.com/opengovsg/FormSG/pull/1140)
+- refactor: migrate checkbox validator to typescript [`#1225`](https://github.com/opengovsg/FormSG/pull/1225)
+- chore(deps-dev): bump eslint-plugin-jest from 24.1.5 to 24.1.8 [`#1308`](https://github.com/opengovsg/FormSG/pull/1308)
+- chore(deps-dev): bump @types/convict from 5.2.2 to 6.0.0 [`#1309`](https://github.com/opengovsg/FormSG/pull/1309)
+- chore(deps-dev): bump stylelint from 13.11.0 to 13.12.0 [`#1307`](https://github.com/opengovsg/FormSG/pull/1307)
+- chore(deps-dev): bump @types/mongodb from 3.6.8 to 3.6.9 [`#1303`](https://github.com/opengovsg/FormSG/pull/1303)
+- chore(deps-dev): bump eslint-plugin-jest from 24.1.5 to 24.1.7 [`#1304`](https://github.com/opengovsg/FormSG/pull/1304)
+- fix(deps): bump aws-sdk from 2.856.0 to 2.858.0 [`#1302`](https://github.com/opengovsg/FormSG/pull/1302)
+- fix(deps): bump libphonenumber-js from 1.9.11 to 1.9.12 [`#1301`](https://github.com/opengovsg/FormSG/pull/1301)
+- chore(deps-dev): bump @types/node from 14.14.31 to 14.14.32 [`#1300`](https://github.com/opengovsg/FormSG/pull/1300)
+- feat: Add submission limits for storage mode form submissions [`#1268`](https://github.com/opengovsg/FormSG/pull/1268)
+- chore(deps-dev): bump ts-jest from 26.5.2 to 26.5.3 [`#1295`](https://github.com/opengovsg/FormSG/pull/1295)
+- chore: change copy & insert secretkeyloss golink  [`#1293`](https://github.com/opengovsg/FormSG/pull/1293)
+- chore(deps-dev): bump testcafe from 1.11.0 to 1.12.0 [`#1294`](https://github.com/opengovsg/FormSG/pull/1294)
+- fix(deps): bump aws-info from 1.1.0 to 1.2.0 [`#1290`](https://github.com/opengovsg/FormSG/pull/1290)
+- chore(deps-dev): bump eslint from 7.20.0 to 7.21.0 [`#1289`](https://github.com/opengovsg/FormSG/pull/1289)
+- fix(deps): bump @sentry/integrations from 6.2.0 to 6.2.1 [`#1288`](https://github.com/opengovsg/FormSG/pull/1288)
+- chore(deps-dev): bump eslint-config-prettier from 8.0.0 to 8.1.0 [`#1287`](https://github.com/opengovsg/FormSG/pull/1287)
+- fix(deps): bump connect-mongo from 4.2.0 to 4.2.2 [`#1286`](https://github.com/opengovsg/FormSG/pull/1286)
+- chore(deps-dev): bump @babel/core from 7.12.17 to 7.13.8 [`#1285`](https://github.com/opengovsg/FormSG/pull/1285)
+- refactor: migrate attachment validator to ts [`#1181`](https://github.com/opengovsg/FormSG/pull/1181)
+- fix(deps): bump has-ansi from 4.0.0 to 4.0.1 [`#1284`](https://github.com/opengovsg/FormSG/pull/1284)
+- fix(deps): bump nodemailer from 6.4.18 to 6.5.0 [`#1282`](https://github.com/opengovsg/FormSG/pull/1282)
+- chore(deps-dev): bump ts-node-dev from 1.1.1 to 1.1.6 [`#1281`](https://github.com/opengovsg/FormSG/pull/1281)
+- fix(deps): bump aws-sdk from 2.848.0 to 2.856.0 [`#1280`](https://github.com/opengovsg/FormSG/pull/1280)
+- chore(deps-dev): bump @typescript-eslint/eslint-plugin [`#1278`](https://github.com/opengovsg/FormSG/pull/1278)
+- fix(deps): bump @babel/runtime from 7.12.18 to 7.13.9 [`#1276`](https://github.com/opengovsg/FormSG/pull/1276)
+- fix(deps): bump twilio from 3.56.0 to 3.57.0 [`#1275`](https://github.com/opengovsg/FormSG/pull/1275)
+- fix(deps): bump bcrypt from 5.0.0 to 5.0.1 [`#1274`](https://github.com/opengovsg/FormSG/pull/1274)
+- refactor: convert frontend MyInfo services to TypeScript [`#1233`](https://github.com/opengovsg/FormSG/pull/1233)
+- chore(deps-dev): bump core-js from 3.9.0 to 3.9.1 [`#1269`](https://github.com/opengovsg/FormSG/pull/1269)
+- chore: add newline in husky .gitignore [`#1272`](https://github.com/opengovsg/FormSG/pull/1272)
+- fix(deps): bump whatwg-fetch from 3.6.1 to 3.6.2 [`#1271`](https://github.com/opengovsg/FormSG/pull/1271)
+- fix(deps): bump connect-mongo from 3.2.0 to 4.2.0 [`#1240`](https://github.com/opengovsg/FormSG/pull/1240)
+- chore(deps-dev): bump @opengovsg/mockpass from 2.6.3 to 2.6.4 [`#1267`](https://github.com/opengovsg/FormSG/pull/1267)
+- chore(deps-dev): bump husky from 4.3.8 to 5.1.3 [`#1105`](https://github.com/opengovsg/FormSG/pull/1105)
+- chore(deps-dev): bump @typescript-eslint/parser from 4.15.2 to 4.16.1 [`#1266`](https://github.com/opengovsg/FormSG/pull/1266)
+- chore(deps-dev): bump @babel/preset-env from 7.12.17 to 7.13.9 [`#1264`](https://github.com/opengovsg/FormSG/pull/1264)
+- chore: Revert "feat: Add submission limits for storage mode form submissions (#1097)" [`#1265`](https://github.com/opengovsg/FormSG/pull/1265)
+- chore(deps-dev): bump @babel/plugin-transform-runtime [`#1263`](https://github.com/opengovsg/FormSG/pull/1263)
+- fix(deps): bump @sentry/browser from 6.2.0 to 6.2.1 [`#1262`](https://github.com/opengovsg/FormSG/pull/1262)
+- chore(deps-dev): bump ts-jest from 26.5.1 to 26.5.2 [`#1261`](https://github.com/opengovsg/FormSG/pull/1261)
+- feat: change logging of incorrect captcha response from error to warn [`#1258`](https://github.com/opengovsg/FormSG/pull/1258)
+- feat(frontend): migrate file handler service to Typescript, update frontend test framework and lint [`#1243`](https://github.com/opengovsg/FormSG/pull/1243)
+- chore(deps-dev): bump stylelint-prettier from 1.1.2 to 1.2.0 [`#1256`](https://github.com/opengovsg/FormSG/pull/1256)
+- fix: remove form.msgSrvcName validation and add human error recovery message [`#1235`](https://github.com/opengovsg/FormSG/pull/1235)
+- fix(deps): bump neverthrow from 4.1.0 to 4.1.1 [`#1255`](https://github.com/opengovsg/FormSG/pull/1255)
+- chore(deps-dev): bump @typescript-eslint/eslint-plugin [`#1253`](https://github.com/opengovsg/FormSG/pull/1253)
+- feat: add timestamp to form submission end page [`#1110`](https://github.com/opengovsg/FormSG/pull/1110)
+- chore(deps-dev): bump @typescript-eslint/parser from 4.15.1 to 4.15.2 [`#1217`](https://github.com/opengovsg/FormSG/pull/1217)
+- feat: Add submission limits for storage mode form submissions [`#1097`](https://github.com/opengovsg/FormSG/pull/1097)
+- chore: merge v5.0.4 into develop [`#1250`](https://github.com/opengovsg/FormSG/pull/1250)
+- chore: merge Release v5.0.3 back to develop branch [`#1248`](https://github.com/opengovsg/FormSG/pull/1248)
 - fix: format workpass status correctly, preview submissions, copy changes [`#1237`](https://github.com/opengovsg/FormSG/pull/1237)
 - feat: update editable fields and clear cookie upon submission [`#1232`](https://github.com/opengovsg/FormSG/pull/1232)
 - style: update end page styling [`#1231`](https://github.com/opengovsg/FormSG/pull/1231)
 - feat: migrate to MyInfo V3 [`#1175`](https://github.com/opengovsg/FormSG/pull/1175)
 - chore: merge v5.0.1 into develop [`#1241`](https://github.com/opengovsg/FormSG/pull/1241)
+- fix: format workpass status correctly, preview submissions, copy changes [`#1237`](https://github.com/opengovsg/FormSG/pull/1237)
+- feat: update editable fields and clear cookie upon submission [`#1232`](https://github.com/opengovsg/FormSG/pull/1232)
+- style: update end page styling [`#1231`](https://github.com/opengovsg/FormSG/pull/1231)
+- feat: migrate to MyInfo V3 [`#1175`](https://github.com/opengovsg/FormSG/pull/1175)
+- chore: merge v4.59.1 into develop [`#1227`](https://github.com/opengovsg/FormSG/pull/1227)
 - build: release v4.59.1 hotfix [`#1226`](https://github.com/opengovsg/FormSG/pull/1226)
 - build: release v4.59.0 [`#1220`](https://github.com/opengovsg/FormSG/pull/1220)
 - build: Release 4.58.2 - hotfix msgSrvcName validation [`#1199`](https://github.com/opengovsg/FormSG/pull/1199)
@@ -63,37 +137,17 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 - build: Release 4.30.1 - Fix field creation on old clients [`#74`](https://github.com/opengovsg/FormSG/pull/74)
 - Release 4.30.0 - acknowledgement for secret key backup, TypeScript migrations [`#67`](https://github.com/opengovsg/FormSG/pull/67)
 - chore: bump version to v5.0.2 [`256d772`](https://github.com/opengovsg/FormSG/commit/256d772f35d69a535a8062e36a6b2c1e5609784e)
+- chore: bump version to 5.0.4 [`9a422f8`](https://github.com/opengovsg/FormSG/commit/9a422f8fceb2a608f4983306376b54bd79cb8f77)
 - fix: check truthiness for all address fields [`bad7228`](https://github.com/opengovsg/FormSG/commit/bad7228c631d274e7ff91063d2c3b6d3b88bb497)
-- chore: bump version to 5.0.0 [`e411cf3`](https://github.com/opengovsg/FormSG/commit/e411cf39f69e676892849e8f3ed1cc0d8ebdcf2f)
-
-#### [v5.0.1](https://github.com/opengovsg/FormSG/compare/v5.0.0...v5.0.1)
-
-> 25 February 2021
-
-- chore: bump version to 5.0.1 [`ea7ddcb`](https://github.com/opengovsg/FormSG/commit/ea7ddcbe030fbe3f1bbd9cb384f40a9558106896)
-- fix: convert res status to uppercase [`8f4aeaf`](https://github.com/opengovsg/FormSG/commit/8f4aeaf76af02cdfe776c1671633909831e2fc5a)
-
-### [v5.0.0](https://github.com/opengovsg/FormSG/compare/v4.59.1...v5.0.0)
-
-> 24 February 2021
-
-- fix: format workpass status correctly, preview submissions, copy changes [`#1237`](https://github.com/opengovsg/FormSG/pull/1237)
-- feat: update editable fields and clear cookie upon submission [`#1232`](https://github.com/opengovsg/FormSG/pull/1232)
-- style: update end page styling [`#1231`](https://github.com/opengovsg/FormSG/pull/1231)
-- feat: migrate to MyInfo V3 [`#1175`](https://github.com/opengovsg/FormSG/pull/1175)
-- chore: merge v4.59.1 into develop [`#1227`](https://github.com/opengovsg/FormSG/pull/1227)
-- feat: remove updateFormValidator [`92f3f75`](https://github.com/opengovsg/FormSG/commit/92f3f75bc760f32bdb495e27eb880d53f1562093)
-- chore: bump version to 5.0.0 [`fb11aee`](https://github.com/opengovsg/FormSG/commit/fb11aee0d19214d824a350c02a3e2a04f89ea726)
-- chore: bump version to v4.59.1 [`a712594`](https://github.com/opengovsg/FormSG/commit/a712594146e294a01cea13e429e4ed03109a1f70)
 
 #### [v4.59.1](https://github.com/opengovsg/FormSG/compare/v4.59.0...v4.59.1)
 
 > 23 February 2021
 
 - fix: add _id key in permissionList object for updateForm validator [`#1224`](https://github.com/opengovsg/FormSG/pull/1224)
-- feat: remove updateFormValidator [`45894b8`](https://github.com/opengovsg/FormSG/commit/45894b89ac36acb6f3a4d2cc22a05bdcdab28925)
+- feat: remove updateFormValidator [`92f3f75`](https://github.com/opengovsg/FormSG/commit/92f3f75bc760f32bdb495e27eb880d53f1562093)
 - chore: bump version to v4.59.0 [`21bee76`](https://github.com/opengovsg/FormSG/commit/21bee768bb40e9eae57fe25b8a3c7b2ea3ccc130)
-- chore: bump version to v4.59.1 [`25c46e7`](https://github.com/opengovsg/FormSG/commit/25c46e77aa1f2d2e109ffae1972645ebb9fd48ac)
+- chore: bump version to v4.59.1 [`a712594`](https://github.com/opengovsg/FormSG/commit/a712594146e294a01cea13e429e4ed03109a1f70)
 
 #### [v4.59.0](https://github.com/opengovsg/FormSG/compare/v4.58.2...v4.59.0)
 
@@ -465,16 +519,16 @@ Generated by [`auto-changelog`](https://github.com/CookPete/auto-changelog).
 - build: Release 4.30.1 - Fix field creation on old clients [`#74`](https://github.com/opengovsg/FormSG/pull/74)
 - Release 4.30.0 - acknowledgement for secret key backup, TypeScript migrations [`#67`](https://github.com/opengovsg/FormSG/pull/67)
 - build: empty commit to trigger PR build [`d0c6583`](https://github.com/opengovsg/FormSG/commit/d0c65838efa6731a0f10e89ff954c132b9f8b854)
+- feat: update table field styling to not rely on multiple divs [`db03da3`](https://github.com/opengovsg/FormSG/commit/db03da33eca2fc0a6174ca58d7dd8b3cfadadcea)
 - fix: return 401 for missing JWT [`e6c1947`](https://github.com/opengovsg/FormSG/commit/e6c19477b05fc4aed90b2db42916220aea2a263c)
-- test: add tests for extractJwt [`16191a9`](https://github.com/opengovsg/FormSG/commit/16191a957be0dc7f63dc4221569fac2794b7d063)
 
 #### [v4.50.2](https://github.com/opengovsg/FormSG/compare/v4.50.1...v4.50.2)
 
 > 16 December 2020
 
-- feat: update table field styling to not rely on multiple divs [`db03da3`](https://github.com/opengovsg/FormSG/commit/db03da33eca2fc0a6174ca58d7dd8b3cfadadcea)
+- feat: update table field styling to not rely on multiple divs [`e857aed`](https://github.com/opengovsg/FormSG/commit/e857aed667145441758f09f311c2b9f16f57645b)
 - fix: email format validation should allow 126/163.com, align frontend and backend validation [`be35522`](https://github.com/opengovsg/FormSG/commit/be35522e15d20521f58fada7ed3164e6c0c0894d)
-- chore: bump version to v4.50.2 [`1ac7be6`](https://github.com/opengovsg/FormSG/commit/1ac7be6cb69553d186ec194682ae25bd98318a8b)
+- chore: bump version to v4.50.2 [`fad62ec`](https://github.com/opengovsg/FormSG/commit/fad62ec5730412201e208332a91286fd53e2b36a)
 
 #### [v4.50.1](https://github.com/opengovsg/FormSG/compare/v4.50.0...v4.50.1)
 

diff --git a/jest.config.js b/jest.config.js
@@ -4,7 +4,11 @@ module.exports = {
   modulePaths: ['<rootDir>'],
   testEnvironment: 'node',
   globalSetup: '<rootDir>/tests/jest-global-setup.js',
-  testPathIgnorePatterns: ['<rootDir>/dist/', '<rootDir>/node_modules/'],
+  testPathIgnorePatterns: [
+    '<rootDir>/dist/',
+    '<rootDir>/node_modules/',
+    '<rootDir>/src/public',
+  ],
   collectCoverageFrom: ['./src/**/*.{ts,js}', '!**/__tests__/**'],
   coveragePathIgnorePatterns: ['./node_modules/', './tests'],
   coverageReporters: ['lcov', 'text'],
@@ -20,4 +24,5 @@ module.exports = {
       isolatedModules: true,
     },
   },
+  setupFilesAfterEnv: ['jest-extended'],
 }