Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use underscore instead of hyphen for plugin name #22 #23

Merged
merged 2 commits into from Aug 5, 2020
Merged

Use underscore instead of hyphen for plugin name #22 #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f5d25e8
Use underscore instead of hyphen for plugin name
Gustry Aug 5, 2020
fb7a929
Update plugins.xml.expected
3nids Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 3 additions & 3 deletions qgispluginci/parameters.py
View file
Open in desktop
Expand Up @@ -13,7 +13,7 @@ class Parameters:
----------
plugin_path: str
The directory of the source code in the repository.
Defaults to: `slugify(plugin_name, separator='_')`
Defaults to: `slugify(plugin_name)`

github_organization_slug: str
The organization slug on SCM host (e.g. Github) and translation platform (e.g. Transifex).
Expand Down Expand Up @@ -117,9 +117,9 @@ def archive_name(self, release_version: str, experimental: bool = False) -> str:
Returns the archive file name
"""
# zipname: use dot before version number
# and not dash since it's causing issues
# and not dash since it's causing issues #22
return '{zipname}{experimental}.{release_version}.zip'.format(
zipname=self.plugin_slug,
zipname=self.plugin_slug.replace('-', '_'),
experimental='-experimental' if experimental else '',
release_version=release_version
)
Expand Down
4 changes: 2 additions & 2 deletions test/plugins.xml.expected
View file
Open in desktop
Expand Up @@ -5,10 +5,10 @@
<version>0.1.2</version>
<qgis_minimum_version>3.2</qgis_minimum_version>
<homepage>https://github.com/opengisch/qgis-plugin-ci</homepage>
<file_name>qgis-plugin-ci-testing.0.1.2.zip</file_name>
<file_name>qgis_plugin_ci_testing.0.1.2.zip</file_name>
<icon>icons/opengisch.png</icon>
<author_name>Denis Rouzaud</author_name>
<download_url>https://github.com/opengisch/qgis-plugin-ci/releases/download/0.1.2/qgis-plugin-ci-testing.0.1.2.zip</download_url>
<download_url>https://github.com/opengisch/qgis-plugin-ci/releases/download/0.1.2/qgis_plugin_ci_testing.0.1.2.zip</download_url>
<uploaded_by>Denis Rouzaud</uploaded_by>
<create_date>1985-07-21</create_date>
<update_date>__TODAY__</update_date>
Expand Down