Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚧(frontend) migrate to react-query v4 & react 18 #1812

Merged
merged 4 commits into from
Nov 15, 2022

Commits on Nov 14, 2022

  1. ⬆️(frontend) migrate to react-query v4 and react 18

    update all required dependencies to support react 18.
    NathanVss committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    76a9b0b View commit details
    Browse the repository at this point in the history
  2. ♻️(frontend) migrate to react 18 compatibility

    react 18 forces to explicitly name the `children` attribute so let's update
    components and hooks.
    NathanVss committed Nov 14, 2022
    Configuration menu
    Copy the full SHA
    011df58 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2022

  1. ✅(frontend) make tests work with react-query v4 and react 18

    most of the tests broke due to the changes induced by the new rendering
    behavior of react 18 and react-query v4, so we changed the approach
    that we had with tests to an approach more based on `waitFor` in order
    to have tests the most render-agnostic as possible.
    NathanVss committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    59b715e View commit details
    Browse the repository at this point in the history
  2. 🐛(frontend) fix infinite loader for product widget

    This bug was occuring when clicking on the button "Login to purchase"
    causing a removal of existing react-query queries. This was caused by
    premature removal of the pending useCourse query which was never notified
    that it had been removed during its loading, resulting in an infinite
    loading state.
    NathanVss committed Nov 15, 2022
    Configuration menu
    Copy the full SHA
    6655ab7 View commit details
    Browse the repository at this point in the history