Skip to content

Commit

Permalink
♻️(frontend) Joanie api client load in test
Browse files Browse the repository at this point in the history
Joanie's api client shouldn't be loaded on test that don't use it.
  • Loading branch information
rlecellier committed Mar 7, 2024
1 parent 3401235 commit 9efc67a
Show file tree
Hide file tree
Showing 8 changed files with 14 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ describe('components/TeacherDashboardCourseList', () => {

await expectNoSpinner('Loading courses...');
expect(
screen.getByRole('heading', { name: /TeacherDashboardCourseList test title/ }),
await screen.findByRole('heading', { name: /TeacherDashboardCourseList test title/ }),
).toBeInTheDocument();

const calledUrls = fetchMock.calls().map((call) => call[0]);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import fetchMock from 'fetch-mock';
import { RichieContextFactory as mockRichieContextFactory } from 'utils/test/factories/richie';
import { OrganizationFactory } from 'utils/test/factories/joanieLegacy';
import { Organization } from 'types/Joanie';
import { JoanieAppWrapper, setupJoanieSession } from 'utils/test/wrappers/JoanieAppWrapper';
import JoanieAppWrapper, { setupJoanieSession } from 'utils/test/wrappers/JoanieAppWrapper';
import useDefaultOrganizationId from '.';

jest.mock('utils/context', () => ({
Expand Down
5 changes: 3 additions & 2 deletions src/frontend/js/hooks/useResources/index.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -222,8 +222,9 @@ describe('useResources (omniscient)', () => {
wrapper: Wrapper,
},
);

expect(result.current.states.isPending).toBe(true);
await waitFor(() => {
expect(result.current.states.isPending).toBe(true);
});
expect(result.current.item).toBe(undefined);
expect(fetchMock.called('https://example.com/api/todos')).toBe(false);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ describe('<CourseLearnersFiltersBar/>', () => {
);

// Two selects should have rendered
const organizationFilter: HTMLInputElement = screen.getByRole('combobox', {
const organizationFilter: HTMLInputElement = await screen.findByRole('combobox', {
name: 'Organization',
});

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import {
CourseProductRelationFactory,
OrganizationFactory,
} from 'utils/test/factories/joanieLegacy';
import { JoanieAppWrapper, setupJoanieSession } from 'utils/test/wrappers/JoanieAppWrapper';
import JoanieAppWrapper, { setupJoanieSession } from 'utils/test/wrappers/JoanieAppWrapper';
import useCourseLearnersFilters from '.';

jest.mock('utils/context', () => ({
Expand Down
5 changes: 3 additions & 2 deletions src/frontend/js/utils/test/render.tsx
Original file line number Diff line number Diff line change
@@ -1,8 +1,9 @@
import { RenderResult, screen, render as testingLibraryRender } from '@testing-library/react';
import React, { ReactElement } from 'react';
import React, { ReactElement, lazy } from 'react';
import { Nullable } from 'types/utils';
import { AppWrapperProps } from './wrappers/types';
import { JoanieAppWrapper } from './wrappers/JoanieAppWrapper';

const JoanieAppWrapper = lazy(() => import('./wrappers/JoanieAppWrapper'));

// ------- setup -------

Expand Down
4 changes: 3 additions & 1 deletion src/frontend/js/utils/test/wrappers/JoanieAppWrapper.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export const setupJoanieSession = () => {
};
};

export const JoanieAppWrapper = ({
const JoanieAppWrapper = ({
children,
intlOptions,
queryOptions,
Expand All @@ -35,3 +35,5 @@ export const JoanieAppWrapper = ({
</BaseJoanieAppWrapper>
);
};

export default JoanieAppWrapper;
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ describe('<TeacherDashboardCourseSidebar/>', () => {
});

await expectNoSpinner('Loading course...');
const link = screen.getByRole('link', {
const link = await screen.findByRole('link', {
name: intl.formatMessage(messages.syllabusLinkLabel),
});
expect(link).toHaveAttribute('href', `/redirects/courses/${course.code}`);
Expand Down

0 comments on commit 9efc67a

Please sign in to comment.