Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generate Certificate #32

Merged
merged 1 commit into from Jun 15, 2021
Merged

Generate Certificate #32

merged 1 commit into from Jun 15, 2021

Conversation

sdemagny
Copy link
Contributor

@sdemagny sdemagny commented Jun 7, 2021

Capture d’écran 2021-06-07 à 02 55 30

@sdemagny sdemagny force-pushed the sdem/generate_certificate branch 2 times, most recently from 78f58c7 to 13e3ec3 Compare June 10, 2021 09:02
jbpenrath
jbpenrath reviewed Jun 10, 2021
View reviewed changes
src/backend/joanie/core/models/products.py Show resolved Hide resolved
src/backend/joanie/core/models/products.py Outdated Show resolved Hide resolved
src/backend/joanie/core/models/products.py Outdated Show resolved Hide resolved
src/backend/joanie/tests/test_models_product.py Outdated Show resolved Hide resolved
@sdemagny sdemagny force-pushed the sdem/generate_certificate branch 2 times, most recently from 641fe1c to 418bbc4 Compare June 15, 2021 06:26
@sdemagny sdemagny requested a review from jbpenrath June 15, 2021 06:26
jbpenrath
jbpenrath approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@jbpenrath jbpenrath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you create a detailed issue to remember to prevent certificate generation if some information are missing please.

src/backend/joanie/core/models/products.py Outdated Show resolved Hide resolved
src/backend/joanie/core/models/certifications.py Show resolved Hide resolved
@sdemagny
✨(backend) Generate PDF certificate
6bfcf0f 
Use marion and howard to generate certificate for an order.
@sdemagny sdemagny merged commit 6bfcf0f into main Jun 15, 2021
@sdemagny sdemagny deleted the sdem/generate_certificate branch June 15, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbpenrath jbpenrath jbpenrath approved these changes

@sampaccoud sampaccoud Awaiting requested review from sampaccoud

Assignees

@sdemagny sdemagny

Labels
feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sdemagny @jbpenrath