🩹(frontend) define SASS variable color out with bootstrap v5 #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carofun
force-pushed
the
fix/renovate-sass
branch
from
5a95c84
to
0b60fe0
Compare
carofun
changed the title
carofun
force-pushed
the
fix/renovate-sass
branch
from
0b60fe0
to
b4d7e12
Compare
carofun
force-pushed
the
fix/renovate-sass
branch
2 times, most recently
from
b2a713e
to
3fb50b2
Compare
Bootstrap version 5 is out. We want Ashley to be updated with latest versions of our dependencies.
$table-head-color used in saas fil is not set-up anymore. The upgrade of the library bootrstrap version 4 to 5 doesn't have this variable pre-configured anymore. As a result, the frontend won't be able to be build anymore. We fix this issue by giving a color to this variable so that Ashley can use bootstrap 5.
carofun
force-pushed
the
fix/renovate-sass
branch
from
3fb50b2
to
44a317b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix different style regression caused by the upgrade of bootstrap v5
$table-head-color used in saas fil wasn't set-up as it was defined in bootstrap variable.
float-left, or float-right are not defined anymore,
links need to be fixed
Proposal
nb : 1 commit
Follow documentation and fix miss out classes
https://getbootstrap.com/docs/5.0/migration/
... to be continued