馃泜(cli) use github token to avoid rate limiting #782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Github has an API rate limiting. This rate limiting could Be increase if we are authenticated. If the environment variable GITHUB_TOKENiIs defined Arnold will use it to auth.
claudusd
force-pushed
the
github_rate_limiting
branch
from
e15f1b0
to
ad3c560
Compare
jmaupetit
reviewed
Sep 8, 2023
| ### Changed | ||
| ### Added | ||
|
|
||
| - Use Gitlab token when call the Github's API |
There was a problem hiding this comment.
Suggested change
| - Use Gitlab token when call the Github's API | |
| - Use GitHub token to call Github's API when the `GITHUB_TOKEN` environment variable is defined |
| @@ -254,9 +254,14 @@ function _get_log_level_name() { | |||
|
|
|||
| # Get the latest Arnold release by querying Github's API | |||
| function _get_latest_release() { | |||
| local auth_header=() | |||
There was a problem hiding this comment.
I prefer declare which is more explicit as it can cast vars:
Suggested change
| local auth_header=() | |
| declare -a auth_header |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
If we execute a lot of Arnold command, this will reach the Github API rate limiting.
When we reach the limit Arnold will fail because it can parse the Github response and stop with this error
Proposal
Use the environment variable
GITHUB_TOKENto authenticate to the Github API and increase the API rate limiting.