Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update queued-submit.yaml #320

Merged
merged 3 commits into from Oct 31, 2022
Merged

Update queued-submit.yaml #320

merged 3 commits into from Oct 31, 2022

Conversation

pavankum
Copy link
Member

importlib_metadata is resolving to some outdated version, pinning it here.

importlib_metadata is resolving to some outdated version, pinning it here.
Copy link
Member

@j-wags j-wags left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not blocking) Hmm, I don't think the toolkit pin should be necessary, since qcsubmit currently pins to openff-toolkit<0.11. And I'm wondering if the importlib_metadata pin should be migrated up to OFFTK, since that's where the first error occurred.

Either way, while I spend my time wondering, we should probably get the validation action working again, so this PR should be good to merge. Let's just remember to unpin it later. Could you add comments justifying the pins so we know when we can remove them?

@pavankum
Copy link
Member Author

Thanks for the review @j-wags. Yeah, the pin on toolkit is not needed, updated that one. Also, pinned importlib_metadata to the newest version since the trouble was when conda resolved it to v1.5 which was incompatible with importlib-metadata, the package with hyphen. I think this should work fine, it worked locally for me.

@pavankum
Copy link
Member Author

And I'm wondering if the importlib_metadata pin should be migrated up to OFFTK, since that's where the first error occurred.

I think there was a version of it which had entry_points() as a dict, and they were maintaining backward compatibility until v5.0.0 which deprecated it completely, so a pin of >= 3.6 may help. This comment is helpful.

@pavankum
Copy link
Member Author

Merging this for now.

@pavankum pavankum merged commit 410db59 into master Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants