fix: ListUsers race conditions
#1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miparnisari
force-pushed
the
list-users-concurrency
branch
from
d8358a9
to
29e8099
Compare
miparnisari
commented
Apr 18, 2024
miparnisari
force-pushed
the
list-users-concurrency
branch
from
29e8099
to
0fcc29d
Compare
miparnisari
changed the title
ListUsers race conditions
sergiught
approved these changes
Apr 19, 2024
jon-whit
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a race condition in ListUsers caused by two goroutines in
expandExclusiontrying to write to the same object. In this PR I fix it and add tests for the other cases (union and intersection) just in case.