Skip to content

CDM 2019 09

Chris Beach edited this page Sep 6, 2019 · 5 revisions

openEQUELLA Community Dev Meeting September 2019

2019-09-05 (US) / 2019-09-06 (AU)

Attendees

  • Chair: Sam F
  • Scribe: Chris B

List of attendees: AaronH, ChrisB, NickC, ChristianM, IanS, JoeS, SamF

Agenda

General Topics

  • Review Action Items
  • Specific Topics (Please add to below list, or email the equella dev list to have an item added)
  • Discuss code enhancements since last CDM
  • Review tech choices, code structures, direction
  • Any tech debt concerns
  • Open PRs to discuss
  • Q&A

Specific Topics

  • Should we add the Stale Bot - IS
  • Consider formalizing committership - CB
  • Are we ready to go to a forking model? - CB
  • Any concerns shutting down the 'equella' github organization? - CB

Minutes

Action items review

  • #1108 - IanS was looking at it, but no real action at the moment. But it is coming to the fore-front due to 2019.1.1 (moving to the symantic versioning / hotfix model). This will become more important.
  • #1107 - This is on Cath's radar.
  • #1106 - on the agenda for today.
  • #1104 - ChrisB created the follow up tickets - can be closed

Specific Topics

  • SamF suggested enhancing the action item flow to have a 'done and reviewed' column.
  • Stale bot - works with issues and a 'stale' label to help note when it becomes stale, it would close a ticket after a time. Folks seem to like the idea.
    • IanS has seen this Action item: setup Stale bot.
  • Formalizing committership - Folks like the idea of formalizing this process in hopes that the dev community will widen in the future. Ideas for voting - issue ticket vs equella-dev google. Suggestion to have the oEQ Advisory Board review and comment. Action item: See what the oEQ AB thinks
  • Forking model: Among other benefits, helps keep the primary code repos clean. Folks seemed alright with this method switch happening now. Action item: update documentation to reflect this switch
  • Remove equella org - no concerns from the groupo Action item: Send a note to the equella-users group, give it a few days, and then remove it

Discuss code enhancements since last CDM

  • IanS - the build system. Travis has been overhauled to run all the tests. Currently the build takes 3 hrs. A lot of time spinning up each test. It'd be helpful to make this process more efficient. Only builds on the main git-flow branches and for each PR. It was broken with the forks, but should be fixed now. Ideally, any new code should have a test with it.
  • IanS - discussed Jolse' PR for the ability to control when scripts are run.
  • ChrisB - Discussed the migration of PingEquella to openEQUELLA-Toolbox:CheckFiles . Noted the purpose and end goal of a background task. CDM folks are interested in how adopters are using it.

Review tech choices, code structures, direction

  • IanS - versioning structure is changing - cleaning up the code and supporting semantic versioning. It's important to note that the file name release scheme is structured and specific. The goal is for the old manager upgrade flow to support the new release naming scheme

Any tech debt concerns

  • IanS - discussed renovate and transitive dependencies. Specific issue is the Apache Tika PR that needs some help to fix the merge conflicts. Now with the new UI tests in place, renovate PRs are starting to be looked at.

Open PRs to discuss

  • #883 / #1067 / #1068 - For now, leave them open but assigned to ChrisB for now.
  • #1118 - Reviewed, could break scripts that look for the headers with underscores. Need to consider if the underscores are just a preference or should be changed to be more standardized.
  • #1144 - new tests in place, just need the merge conflicts fixed. Note that autotests don't use CAS, but it would confirm normal login works
  • #1180 - needs another rebase
  • #1186 - Needs a bit more rework, but pretty cool effort
  • #1196 - Could be useful with some more Travis work (tech debt concern) Action item: close it off and open a ticket
  • #1202 - new functionality, open for review. Need to review failed tests

Q&A

  • 2019-10 CDB: NickC - Chair, Sam - Scribe, normal meeting time.