Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Data too long for column 'resource_id' #435

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shadinaif
Copy link
Contributor

@shadinaif shadinaif commented Dec 25, 2023

when the course id is a little bit long, the lti xblock id becomes too long for resource_id to handle

To reproduce:

  • Create a course with long ID. For example: course-v1:Public+TEST_IT_01+TEST_IT_01_Dec_2023
  • Add lti_consumer in Advanced settings for the course
  • Try to add an LTI component in the course with version 1.3
  • The unit crashes
    Screenshot from 2023-12-25 14-00-00

we tried that on the latest https://sandbox.openedx.org

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 25, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @shadinaif! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@shadinaif
Copy link
Contributor Author

For your review @OmarIthawi, please

Copy link

codecov bot commented Dec 25, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.85%. Comparing base (83fa9e0) to head (c5851e6).

❗ Current head c5851e6 differs from pull request most recent head f6fbae4. Consider uploading reports for the commit f6fbae4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #435      +/-   ##
==========================================
+ Coverage   97.83%   97.85%   +0.01%     
==========================================
  Files          77       78       +1     
  Lines        6710     6709       -1     
==========================================
  Hits         6565     6565              
+ Misses        145      144       -1     
Flag Coverage Δ
unittests 97.85% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@OmarIthawi
Copy link
Member

@shadinaif shadinaif force-pushed the shadinaif/fix-short-resource-id branch from bb1ad9b to 454346f Compare January 15, 2024 04:53
@shadinaif
Copy link
Contributor Author

please check now @OmarIthawi

Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Shadi. One more thing please.

lti_consumer/migrations/0018_auto_20231225_0556.py Outdated Show resolved Hide resolved
Copy link
Member

@OmarIthawi OmarIthawi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks @shadinaif!!

@mphilbrick211
Copy link

Hi @OmarIthawi and @shadinaif! Is this pull request still needed?

@OmarIthawi
Copy link
Member

Yes @mphilbrick211, we needed it to get merged but it wasn't triaged since Jan 25th.

@shadinaif there's a new changelog update that conflicts with this pull request, kindly rebase and fix it.

@shadinaif shadinaif force-pushed the shadinaif/fix-short-resource-id branch from c5851e6 to c0f4d1f Compare April 8, 2024 12:20
when the course id is a little bit long, the lti xblock id becomes too long for resource_id to handle
@shadinaif shadinaif force-pushed the shadinaif/fix-short-resource-id branch from c0f4d1f to f6fbae4 Compare April 8, 2024 12:28
@shadinaif
Copy link
Contributor Author

shadinaif commented Apr 8, 2024

Rebased. But codecov is failing for no reason ¯\(ツ)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

None yet

4 participants