Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENT-8859] Show dropdown filters post AI Curation results (WIP) #419

Merged
merged 3 commits into from
May 22, 2024

Conversation

mahamakifdar19
Copy link
Contributor

Ticket

https://2u-internal.atlassian.net/browse/ENT-8859

Description

After the AI Curation results are displayed, user should be further able to use dropdown filters such as Skills, Subjects, and Partner to filter the data. To meet this requirement, I've introduced a flag that toggles to true upon fetching AI Curation results. This flag hides the search box and reveals the dropdown filters.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@mahamakifdar19 mahamakifdar19 marked this pull request as draft May 13, 2024 08:26
@jajjibhai008 jajjibhai008 marked this pull request as ready for review May 22, 2024 09:59
Copy link

@muhammad-ammar muhammad-ammar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jajjibhai008 jajjibhai008 merged commit 9f361f5 into main May 22, 2024
5 checks passed
@jajjibhai008 jajjibhai008 deleted the maham/ENT-8859 branch May 22, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants