Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: use shared browserslist config #238

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jawayria
Copy link
Contributor

@Jawayria Jawayria commented Jun 3, 2022

Removes custom browserslist configuration in favor of using a shared configuration.
Removes is-es5 check in CI since ES5 was only needed for IE 11 support which is dropped. The supported browsers defined by the shared configuration all natively support ES6.
This change reduces the resultant asset bundle size.

Created this PR due to some issues in rebasing the older PR.

For all changes

  • Ensure adequate tests are in place (or reviewed existing tests cover changes)

Only if submitting a visual change

  • Ensure to attach screenshots
  • Ensure to have UX team confirm screenshots

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #238 (27a7800) into main (c7d5eca) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #238   +/-   ##
=======================================
  Coverage   82.47%   82.47%           
=======================================
  Files          37       37           
  Lines         582      582           
  Branches      185      185           
=======================================
  Hits          480      480           
  Misses         99       99           
  Partials        3        3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c7d5eca...27a7800. Read the comment docs.

@Jawayria
Copy link
Contributor Author

Jawayria commented Aug 5, 2022

Frontend Bom will be carrying these forward.
cc: @abdullahwaheed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants