Skip to content

Commit

Permalink
fix: upgrade paraagon and make required Hero media query changes (#179)
Browse files Browse the repository at this point in the history
* fix: required Hero media query changes

* feat: Upgrade paragon and apply media query fix

* feat: unused classes
  • Loading branch information
binodpant committed Dec 20, 2021
1 parent 4a80c68 commit 8c0659a
Show file tree
Hide file tree
Showing 3 changed files with 45 additions and 65 deletions.
82 changes: 29 additions & 53 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
"@edx/frontend-component-header": "2.4.1",
"@edx/frontend-enterprise-catalog-search": "2.2.5",
"@edx/frontend-platform": "1.14.3",
"@edx/paragon": "^16.16.0",
"@edx/paragon": "^17.2.0",
"@fortawesome/fontawesome-svg-core": "1.2.35",
"@fortawesome/free-brands-svg-icons": "5.15.3",
"@fortawesome/free-regular-svg-icons": "5.15.3",
Expand Down
26 changes: 15 additions & 11 deletions src/components/hero/Hero.jsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { injectIntl, intlShape } from '@edx/frontend-platform/i18n';
import {
Container, ExtraExtraLarge, ExtraLarge, Image, Large, Medium,
Container, Image, useMediaQuery, breakpoints,
} from '@edx/paragon';
import PropTypes from 'prop-types';
import React from 'react';
Expand Down Expand Up @@ -39,25 +39,29 @@ LargeImage.propTypes = {
alt: PropTypes.string.isRequired,
};

const Desktop = ({ children }) => {
const isDesktop = useMediaQuery({ minWidth: breakpoints.large.minWidth });
return isDesktop ? children : null;
};
const Tablet = ({ children }) => {
const isTablet = useMediaQuery({ minWidth: breakpoints.medium.minWidth, maxWidth: breakpoints.medium.maxWidth });
return isTablet ? children : null;
};

const Hero = ({ intl, text, highlight }) => {
const alt = intl.formatMessage(messages['hero.image.alt']);

return (
<section className="hero">
<Container size="lg" className="hero__content">
<h1 className="display-1"><Highlighted text={text} highlight={highlight} /></h1>
<div>
<Large>
<SmallImage alt={alt} />
</Large>
<Medium>
<SmallImage alt={alt} />
</Medium>
<ExtraExtraLarge>
<Desktop>
<LargeImage alt={alt} />
</ExtraExtraLarge>
<ExtraLarge>
</Desktop>
<Tablet>
<LargeImage alt={alt} />
</ExtraLarge>
</Tablet>
</div>
</Container>
</section>
Expand Down

0 comments on commit 8c0659a

Please sign in to comment.