fix: exam content will not be viewable if due date has passed #872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alangsto
force-pushed
the
alangsto/prevent_viewing_exams
branch
from
3db2805
to
0e3a9ba
Compare
alangsto
force-pushed
the
alangsto/prevent_viewing_exams
branch
2 times, most recently
from
062502c
to
1893064
Compare
schenedx
approved these changes
Jun 7, 2021
edx_proctoring/api.py
Outdated
| attempt['is_status_acknowledged'], | ||
| exam | ||
| ) else 'proctored_exam/submitted.html' | ||
| ) and getattr(settings, 'PROCTORED_EXAM_VIEWABLE_PAST_DUE', False)) else 'proctored_exam/submitted.html' |
There was a problem hiding this comment.
#NIT Can we please assign this variable to a variable in the constant.py? This is slightly more difficult to read?
|
Maybe you just need to re-run build? The build error doesn't look like it's code related. |
alangsto
force-pushed
the
alangsto/prevent_viewing_exams
branch
3 times, most recently
from
da3e1e2
to
dc2ec57
Compare
Previously, if a learner had submitted their proctored exam and if the exam due date had passed, they were able to acknowledge their status and view the exam content. This is no longer wanted and poses an integrity threat. Students will not be able to acknowledge their status after this change, and exam content will only be viewable if the django setting PROCTORED_EXAM_VIEWABLE_PAST_DUE is set to True.
alangsto
force-pushed
the
alangsto/prevent_viewing_exams
branch
from
dc2ec57
to
6ef85e5
Compare
|
@schenedx I believe that codecov is experiencing issues right now (see codecov/codecov-action#330), so I've temporarily disabled the setting |
|
@alangsto Got it. That's sad. Disable it temporally make sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MST-846
Previously, if a learner had submitted their proctored exam and if the exam due date had passed, they were able to acknowledge their status and view the exam content. This is no longer wanted and poses an integrity threat. Students will not be able to acknowledge their status after this change, and exam content will only be viewable if the django setting PROCTORED_EXAM_VIEWABLE_PAST_DUE is set to True.
Pre-Merge Checklist:
edx_proctoring/__init__.pyandpackage.jsonif these changes are to be released.CHANGELOG.rstPost-Merge: