Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feanil/python311 reqs #34788

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

feanil/python311 reqs #34788

wants to merge 4 commits into from

Conversation

feanil
Copy link
Contributor

@feanil feanil commented May 13, 2024

  • build: Drop testing with Mongo 4.4 and Python 3.8
  • chore: Run make upgarde with Python 3.11
  • build: Add a missing import for importlib_metadata.
  • chore: Run make upgrade
  • fix: Fix an ora2 related test.
  • fix: Update to adjust for new scipy.stats.mode behavior.

Copy link
Member

@kdmccormick kdmccormick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving under the assumption that you're just splitting up #34780 into smaller PRs

@feanil
Copy link
Contributor Author

feanil commented May 14, 2024

We'll come back to this after Wednesday May 22.

This was being pulled in as a transitive dependency before but it turns
out we need this directly for the usage in
openedx/core/djangoapps/plugins/i18n_api.py

We add it to kernel.in before re-building the requirements files.
Previously the default for the `keepdims` parameter was True, but as of
SciPy 1.11.0 it is false. This is actually the behavior we want here
since we only care about the mode value and not other values.

https://docs.scipy.org/doc/scipy/release/1.11.0-notes.html#expired-deprecations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants