chore: update all github actions #34708
Conversation
irtazaakram
commented
May 7, 2024
•
irtazaakram
commented
- Resolves Update GitHub Actions #34748
|
|
|
Needs to updated GitHub Actions runner Current version: https://github.com/actions/runner/releases/tag/v2.288.1 Support for Node20 was added in https://github.com/actions/runner/releases/tag/v2.315.0 new GitHub Actions require runner to updated to support node 20. |
irtazaakram
force-pushed
the
update-github-actions
branch
from
e38ee29
to
c53abce
Compare
irtazaakram
force-pushed
the
update-github-actions
branch
from
fc5513e
to
d15d8a6
Compare
| @@ -9,20 +9,21 @@ on: | |||
| jobs: | |||
| collect-and-verify: | |||
| if: (github.repository == 'edx/edx-platform-private') || (github.repository == 'openedx/edx-platform' && (startsWith(github.base_ref, 'open-release') == false)) | |||
| runs-on: [ edx-platform-runner ] | |||
| runs-on: [ "ubuntu-20.04" ] | |||
There was a problem hiding this comment.
💡 Will be great if we could centralize the ubuntu versions into a constants file or in some open-edx-setup-action
There was a problem hiding this comment.
At the very least, we should make it a matrix setting and pull it up to the top of this file so we can change it in one place and get all the sets to change.
There was a problem hiding this comment.
Tried to setup env variable here https://github.com/openedx/edx-platform/actions/runs/9281219260/workflow but gha doesn't allow this syntax.
https://docs.github.com/en/actions/using-workflows/reusing-workflows seems to be the way here for DRY it.
|
Test run on fork: irtazaakram#6 |
| @@ -9,20 +9,21 @@ on: | |||
| jobs: | |||
| collect-and-verify: | |||
| if: (github.repository == 'edx/edx-platform-private') || (github.repository == 'openedx/edx-platform' && (startsWith(github.base_ref, 'open-release') == false)) | |||
| runs-on: [ edx-platform-runner ] | |||
| runs-on: [ "ubuntu-20.04" ] | |||
There was a problem hiding this comment.
At the very least, we should make it a matrix setting and pull it up to the top of this file so we can change it in one place and get all the sets to change.
