Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: reduce cache timeot value to comply with usecase #34584

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GlugovGrGlib
Copy link
Member

Description

This PR reduces the default timeout value for caching of the users count on gradebook to 10 minutes, and also drops a cache key on enrollment status change, so the actual count of enrolled users on the course will be displayed.

Supporting information

The cached value can be seen on the gradebook page in gradebook MFE:
image

Testing instructions

  1. Open Gradebook for a specific course, try to create several filtered views
  2. Enroll several new users into the course
  3. Open Gradebook page once again, the number of total users enrolled into the course should be updated, newly enrolled users appear in the paginated list of users

Other information

The original PR that was removing cache completely to overcome this issue - #33617.

@openedx-webhooks
Copy link

openedx-webhooks commented Apr 23, 2024

Thanks for the pull request, @GlugovGrGlib! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Apr 23, 2024
@GlugovGrGlib GlugovGrGlib marked this pull request as draft April 23, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
Status: Waiting on Author
Development

Successfully merging this pull request may close these issues.

None yet

2 participants