build: upgrading django-auth-toolkit and oauthlib. #30634
Conversation
| # for details https://github.com/oauthlib/oauthlib/blob/v3.2.0/oauthlib/oauth2/rfc6749/tokens.py#L303 | ||
|
|
||
| token = token_generator.create_token(request, refresh_token=True) | ||
| token_generator.request_validator.save_token(token, request) |
There was a problem hiding this comment.
Issue about OIDC request_type "code token" does not save access token.
There was a problem hiding this comment.
If I understand correctly, the old create_token() method had a save_token optional parameter that defaulted to True. Since that param was dropped, we have replaced it with this explicit call to save_token. This looks fine.
awais786
force-pushed
the
django-oauth-toolkit
branch
3 times, most recently
from
e2bae37
to
a478cce
Compare
| # for details https://github.com/oauthlib/oauthlib/blob/v3.2.0/oauthlib/oauth2/rfc6749/tokens.py#L303 | ||
|
|
||
| token = token_generator.create_token(request, refresh_token=True) | ||
| token_generator.request_validator.save_token(token, request) |
There was a problem hiding this comment.
If I understand correctly, the old create_token() method had a save_token optional parameter that defaulted to True. Since that param was dropped, we have replaced it with this explicit call to save_token. This looks fine.
| # save_token` has been deprecated, it was not called internally | ||
| # If you do, call `request_validator.save_token()`. | ||
| # for details https://github.com/oauthlib/oauthlib/blob/v3.2.0/oauthlib/oauth2/rfc6749/tokens.py#L303 | ||
|
|
There was a problem hiding this comment.
I'd remove this comment. It seems useful as a comment in the PR, but once this code change lands, the comment just is confusing.
| # save_token` has been deprecated, it was not called internally | |
| # If you do, call `request_validator.save_token()`. | |
| # for details https://github.com/oauthlib/oauthlib/blob/v3.2.0/oauthlib/oauth2/rfc6749/tokens.py#L303 |
requirements/constraints.txt
Outdated
| # greater version has breaking changes. | ||
| # https://github.com/jazzband/django-oauth-toolkit/blob/master/CHANGELOG.md#200-2022-04-24 | ||
| django-oauth-toolkit<2.0.0 |
There was a problem hiding this comment.
Please alphabetize. Thanks.
I am searching it in both orgs and share my findings. |
| # https://github.com/jazzband/django-oauth-toolkit/blob/master/CHANGELOG.md#200-2022-04-24 | ||
| django-oauth-toolkit<2.0.0 | ||
|
|
||
|
|
There was a problem hiding this comment.
Nit: single line break for consistency.
|
Verified LTI zoom. It is integrated and working.
|
mumarkhan999
force-pushed
the
django-oauth-toolkit
branch
from
662f69e
to
9d7d6af
Compare
** method names changed from `construct_base_string` to `signature_base_string` and from `normalize_base_string_uri` to `base_string_uri`. ** explicitly trigger the `save_token` call. for more details check * oauthlib/oauthlib#755 * https://github.com/oauthlib/oauthlib/pull/651/files
mumarkhan999
force-pushed
the
django-oauth-toolkit
branch
from
9d7d6af
to
737dab9
Compare
|
FYI: I don't plan on paying attention to this PR until you ask again. I am going to stop watching. I don't want to bring my head into this unless and until it makes sense to. Thank you! |
|
Closing this PR in favor of #33341 |
https://2u-internal.atlassian.net/browse/BOM-3360
django-oauth-toolkit greater version has some breaking changes so I added a new pin. Further upgrade need more discovery.*
https://github.com/jazzband/django-oauth-toolkit/blob/master/CHANGELOG.md#200-2022-04-24
Changes details
Method names changes
PR with this change.
Issue about OIDC request_type "code token" does not save access token.
In version v3.0.1 it has a param
and it was saving the token.
But in version v3.2.0 it ask to save it explicitly.