Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BOM-2849: Upgrade django-cors-headers to 3.9.0 #28846

Merged
merged 1 commit into from Oct 1, 2021

Conversation

mzulqarnain1
Copy link
Contributor

@mzulqarnain1 mzulqarnain1 commented Sep 27, 2021

Relevant JIRA : https://openedx.atlassian.net/browse/BOM-2849

Following is the changelog for django-cors-headers post v3.5.0, It seems that we are good to go to the latest version.

image

Copy link
Member

@UsamaSadiq UsamaSadiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to go. You should add a doc link for the new github dependency format change (moving the eggname from the end of the url to start).

@@ -1091,9 +1087,9 @@ xblock==1.5.1
# xblock-google-drive
# xblock-poll
# xblock-utils
git+https://github.com/edx-solutions/xblock-drag-and-drop-v2@v2.3.5#egg=xblock-drag-and-drop-v2==2.3.5
xblock-drag-and-drop-v2 @ git+https://github.com/edx-solutions/xblock-drag-and-drop-v2@v2.3.5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a change in the latest version of pip-tools where they started using direct reference instead of egg name.
https://github.com/jazzband/pip-tools/blob/master/CHANGELOG.md#630-2021-09-21

PR where changes were made
jazzband/pip-tools#1455

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@UsamaSadiq UsamaSadiq changed the title BOM-2849: Upgrade django-cors-headers to 3.8.0 BOM-2849: Upgrade django-cors-headers to 3.9.0 Oct 1, 2021
@UsamaSadiq UsamaSadiq merged commit ee68bfe into master Oct 1, 2021
@UsamaSadiq UsamaSadiq deleted the cors-headers-latest branch October 1, 2021 11:19
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants