Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Downgrade to pytest-django 3.8.0 for now #23566

Merged
merged 3 commits into from Apr 1, 2020
Merged

Downgrade to pytest-django 3.8.0 for now #23566

merged 3 commits into from Apr 1, 2020

Conversation

jmbowman
Copy link
Contributor

@jmbowman jmbowman commented Apr 1, 2020

We'll upgrade this again along with pytest once pytest-dev/pytest#6925 is resolved.

@jmbowman jmbowman requested a review from a team April 1, 2020 16:11
@jmbowman
Copy link
Contributor Author

jmbowman commented Apr 1, 2020

It looks like a flaky error in test class DB setup outside a transaction was mucking things up for the rest of the test shard. I didn't try to fix the flakiness, but this should at least limit the blast radius to just that test class. We really need to start using setUpTestData() more consistently.

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

@jmbowman jmbowman merged commit 9ef0aa4 into master Apr 1, 2020
@jmbowman jmbowman deleted the jmbowman/downgrade-pytest-django branch April 1, 2020 18:17
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

timmc-edx added a commit that referenced this pull request Aug 7, 2020
@timmc-edx
Unpin django-pytest now that pytest has upgraded to 5.4.0 and later
998b311 
- Originally pinned in PR #23566
- pytest was unpinned in PR #24717 and upgraded to v6+
@timmc-edx timmc-edx mentioned this pull request Aug 7, 2020
Merged
timmc-edx added a commit that referenced this pull request Aug 7, 2020
@timmc-edx
Unpin django-pytest now that pytest has upgraded to 5.4.0 and later (#…
b04f784 
…24730)

- Originally pinned in PR #23566
- pytest was unpinned in PR #24717 and upgraded to v6+
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feanil feanil feanil approved these changes

@fysheets fysheets fysheets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jmbowman @edx-status-bot @edx-pipeline-bot @feanil @fysheets