Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TE-2659 Fix coverage with remote xdist workers #18636

Merged
merged 1 commit into from Jul 24, 2018
Merged

Conversation

jmbowman
Copy link
Contributor

Working around a bug in pytest-cov by explicitly enumerating the modules to be covered on the pytest command line. I also had to expand the rsync directories to cover all the code for which coverage is measured; otherwise setup fails with ValueError: arg lms not relative to an rsync root.

We can remove some of this code if the PR above gets included in a pytest-cov release.

@edx-status-bot
Copy link

Your PR has finished running tests. There were no failures.

Copy link
Contributor

@michaelyoungstrom michaelyoungstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, and thanks for submitting a PR to pytest-cov!

@jmbowman jmbowman merged commit c158a31 into master Jul 24, 2018
@jmbowman jmbowman deleted the jmbowman/TE-2659 branch July 24, 2018 22:04
@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the staging environment in preparation for a release to production on Thursday, July 26, 2018.

@edx-pipeline-bot
Copy link
Contributor

EdX Release Notice: This PR has been deployed to the production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants