Add js test for analytics event on LMS receipt page

[zubair-arbi]

ECOM-4281
@awais786 @ahsan-ul-haq @tasawernawaz @waheedahmed

• Add js test for analytics event Completed Order on LMS checkout receipt page.
• Remove underscore.string dependency and use global string_utils methods.

Initial PR (Merged): https://github.com/edx/edx-platform/pull/12238
Reverted PR (falkytest): https://github.com/edx/edx-platform/pull/12273
Related PR (Underscore string changes): https://github.com/edx/edx-platform/pull/11631

[zubair-arbi]

jenkins run js
jenkins run lettuce

[zubair-arbi]

@andy-armstrong @AlasdairSwan Including following code

'js/commerce/views/receipt_view': {
    exports: 'edx.commerce.ReceiptView',
    deps: ['jquery', 'backbone', 'underscore', 'underscore.string'],
    init: function() {
        // Set global variables that the receipt code is expecting to be defined
        require([
            'underscore',
            'underscore.string'
        ], function (_, str) {
            window._ = _;
            window._s = str;
        });
    }
 },

in the file lms/static/js/spec/main.js doesn't help resolve the error (for js spec test):

Firefox 28.0.0 (Ubuntu 0.0.0) ERROR
  TypeError: _.str is undefined
  at /edx/app/edxapp/edx-platform/lms/static/js/commerce/views/receipt_view.js:28

while doing _.mixin(_.str.exports());

Is there is something we are missing?

[andy-armstrong]

You could also add:

window._.str = str;

I suppose.

Note that we are working to get rid of Underscore.string because it is mostly not needed with the latest browsers. My recommendation would be to remove this line, and to try to remove any usages of it in your code. @bjacobel might be able to offer some advice as he's worked on this recently.

[ahsan-ul-haq]

@andy-armstrong Here we have removed _.str usage and also instead of using _.sprintf which is method of _.str we have manually formatted the urls. So do you think it is a good enough solution for now or would you like to suggest some other solution.
FYI: @bjacobel, @symbolist

[bjacobel]

Depending on what utils in Underscore.string you're using, the UI Toolkit's StringUtils may fill your needs. Just looking through this quickly seems like you're just using _.sprintf, which can be replaced by StringUtils.interpolate easily.

Here's an example of a file I removed sprintf's from a few weeks ago:

[ahsan-ul-haq]

jenkins run bokchoy

[zubair-arbi]

@AlasdairSwan @schenedx @bjacobel I have used global method interpolate_text instead of using underscore.string method _.sprintf.
Please review.

[zubair-arbi]

@rlucioni It would be helpful if you can review too.

[andy-armstrong]

Thanks for removing the Underscore.string usages. This wasn't clear, but interpolate_text is being deprecated in favor of StringUtils.interpolate and HtmlUtils.interpolateHtml. In your case, use edx.StringUtils.interpolate as this code is not using RequireJS.

See the safe template guidelines here:

http://edx-developer-guide.readthedocs.io/en/latest/conventions/safe_templates.html

[ahsan-ul-haq]

@andy-armstrong @AlasdairSwan The PR is ready could you give your final thoughts about it.
FYI: @bjacobel

[AlasdairSwan]

Looks good 👍

[ahsan-ul-haq]

@andy-armstrong waiting for your review.

[andy-armstrong]

👍