More code review fixes

openedx · Mar 22, 2016 · fee4f63 · fee4f63
1 parent 08bcde2
commit fee4f63
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/lms/static/js/student_profile/views/learner_profile_fields.js b/lms/static/js/student_profile/views/learner_profile_fields.js
@@ -1,10 +1,13 @@
 ;(function(define, undefined) {
     'use strict';
     define([
-        'gettext', 'jquery', 'underscore', 'backbone', 'js/views/fields', 'js/views/image_field',
+        'gettext', 'jquery', 'underscore', 'backbone',
         'edx-ui-toolkit/js/utils/html-utils',
+        'edx-ui-toolkit/js/utils/string-utils',
+        'js/views/fields',
+        'js/views/image_field',
         'backbone-super'
-    ], function(gettext, $, _, Backbone, FieldViews, ImageFieldView, HtmlUtils) {
+    ], function(gettext, $, _, Backbone, HtmlUtils, StringUtils, FieldViews, ImageFieldView) {
 
         var LearnerProfileFieldViews = {};
 
@@ -56,7 +59,7 @@
             },
 
             imageAltText: function() {
-                return HtmlUtils.interpolateHtml(
+                return StringUtils.interpolate(
                     gettext('Profile image for {username}'),
                     {username: this.model.get('username')}
                 );

diff --git a/lms/templates/components/header/header.underscore b/lms/templates/components/header/header.underscore
@@ -2,7 +2,7 @@
     <div class="page-header-main">
         <div class="sr-is-focusable" tabindex="-1"></div>
         <% if (breadcrumbs !== null && breadcrumbs.length > 0) { %>
-            <nav class="breadcrumbs" aria-label="<%= HtmlUtils.ensureHtml(nav_aria_label) %>">
+            <nav class="breadcrumbs" aria-label="<%- nav_aria_label %>">
             <% _.each(breadcrumbs, function (breadcrumb) { %>
                 <a class="nav-item" href="<%= breadcrumb.url %>"><%= HtmlUtils.ensureHtml(breadcrumb.title) %></a>
                 <span class="icon fa-angle-right" aria-hidden="true"></span>