Clean up unnecessary usage of HtmlUtils.setHtml

openedx · Mar 22, 2016 · 57e5d51 · 57e5d51
1 parent a0970d6
commit 57e5d51
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 7 deletions.
diff --git a/lms/djangoapps/teams/static/teams/js/views/edit_team_members.js b/lms/djangoapps/teams/static/teams/js/views/edit_team_members.js
@@ -47,7 +47,7 @@
                         );
                     }
                     else {
-                        HtmlUtils.setHtml(this.$el, '<ul class="edit-members"></ul>');
+                        HtmlUtils.setHtml(this.$el, HtmlUtils.HTML('<ul class="edit-members"></ul>'));
                         this.renderTeamMembers();
                     }
                     return this;

diff --git a/lms/djangoapps/teams/static/teams/js/views/topic_card.js b/lms/djangoapps/teams/static/teams/js/views/topic_card.js
@@ -19,8 +19,7 @@
 
                 render: function() {
                     var teamCount = this.model.get('team_count');
-                    HtmlUtils.setHtml(
-                        this.$el,
+                    this.$el.text(
                         StringUtils.interpolate(
                             ngettext('{team_count} Team', '{team_count} Teams', teamCount),
                             {team_count: teamCount}

diff --git a/lms/static/js/views/fields.js b/lms/static/js/views/fields.js
@@ -290,7 +290,7 @@
             },
 
             updateValueInField: function () {
-                HtmlUtils.setHtml(this.$('.u-field-value '), this.modelValue());
+                this.$('.u-field-value ').text(this.modelValue());
             }
         });
 
@@ -429,7 +429,7 @@
                     value = this.options.placeholderValue || '';
                 }
                 this.$('.u-field-value').attr('aria-label', this.options.title);
-                HtmlUtils.setHtml(this.$('.u-field-value-readonly'), value);
+                this.$('.u-field-value-readonly').text(value);
 
                 if (this.mode === 'display') {
                     this.updateDisplayModeClass();

diff --git a/lms/static/js/views/image_field.js b/lms/static/js/views/image_field.js
@@ -189,13 +189,13 @@
             showUploadInProgressMessage: function() {
                 this.$('.u-field-upload-button').css('opacity', 1);
                 HtmlUtils.setHtml(this.$('.upload-button-icon'), this.iconProgressHtml);
-                HtmlUtils.setHtml(this.$('.upload-button-title'), this.titleUploading);
+                this.$('.upload-button-title').text(this.titleUploading);
             },
 
             showRemovalInProgressMessage: function() {
                 this.$('.u-field-remove-button').css('opacity', 1);
                 HtmlUtils.setHtml(this.$('.remove-button-icon'), this.iconProgressHtml);
-                HtmlUtils.setHtml(this.$('.remove-button-title'), this.titleRemoving);
+                this.$('.remove-button-title').text(this.titleRemoving);
             },
 
             setCurrentStatus: function(status) {